Commit Graph

627 Commits

Author SHA1 Message Date
Ryan Summers 2b6e6f59a4 Adding comment about sample rate 2021-01-04 18:09:16 +01:00
Ryan Summers 7ecd08d86b More updates after PR review 2021-01-04 18:04:01 +01:00
Ryan Summers 67b6990fc0 Addressing PR review 2021-01-04 17:12:24 +01:00
bors[bot] 1bf71f335b
Merge #210
210: iir_int: add optimized integer iir implementation r=jordens a=jordens



Co-authored-by: Robert Jördens <rj@quartiq.de>
2020-12-22 15:51:39 +00:00
Robert Jördens cc42c0c477 iir_int: add optimized integer iir implementation 2020-12-22 16:49:12 +01:00
bors[bot] 40e12e8a7d
Merge #209
209: Rj/refine atan2 r=jordens a=jordens



Co-authored-by: Robert Jördens <rj@quartiq.de>
2020-12-20 20:10:44 +00:00
Robert Jördens 8d9af70c19 trig/atan2: refine
* use dynamic scaling of the inputs to get accurate ratios (effectively
  floating point) to maintain accuracy for small arguments
* this also allows shifting later and keep more bits
* use u32 ratio to keep one more bit
* merge the corner case unittests into the big test value list
* print rms, absolute and axis-relative angle
* simplify the correction expression to get rid of one multiplication
* use 5 bit for the correction constant and 15 bits for r
* least squares optimal correction constant, this lowers the max error
  below 5e-5
2020-12-20 21:07:23 +01:00
Robert Jördens 12d5945d81 dsp/testing: simplify 2020-12-20 20:23:32 +01:00
bors[bot] 2f122d12fa
Merge #207
207: atan r=jordens a=matthuszagh

Adds 2-argument arctangent function. Parameters and result are `i32` integers for fast computation. Only the 16 MSBs of the inputs are used (16 LSBs are discarded). The x and y inputs can range from -1 to 1, which corresponds to `i32::MIN` and `i32::MAX`, respectively. The output ranges from -pi to pi, which corresponds to `i32::MIN` and `i32::MAX`, respectively.

- [godbolt](https://rust.godbolt.org/z/nahKrT)

# Related
- #206

Co-authored-by: Matt Huszagh <huszaghmatt@gmail.com>
2020-12-17 22:28:55 +00:00
Matt Huszagh 7e794373f4 atan2: fix output range description 2020-12-17 14:21:39 -08:00
Matt Huszagh 3125365a15 add atan2 host benchmark 2020-12-17 14:01:57 -08:00
Matt Huszagh 17cf71f22b atan2: replace min, max with x, y 2020-12-17 11:39:32 -08:00
Matt Huszagh 9c5e68ceea atan2: test min and max angle inputs 2020-12-17 11:34:39 -08:00
Matt Huszagh 6ffc42021e move atan2 test before cossin test to mimic function order 2020-12-17 10:09:12 -08:00
Matt Huszagh 09a744f59c dsp: move iir generic math functions to top-level module scope 2020-12-17 10:04:48 -08:00
Matt Huszagh 56641d5838 atan2: specify why we cannot use more than 15 bits for the atan argument 2020-12-17 10:02:35 -08:00
Matt Huszagh 1f28949bc5 atan2: store sign bits and greater of |x| and |y| 2020-12-17 09:47:39 -08:00
Matt Huszagh cb38c3e3bd atan2: clarify sharing bits between atan argument and constant factors 2020-12-17 09:31:38 -08:00
Matt Huszagh 5717991ada atan2: result range is from i32::MIN+1 to i32::MAX 2020-12-17 09:31:18 -08:00
Matt Huszagh d7111a3aa8 dsp/trig: let compiler infer type parameter in atan2 abs call 2020-12-17 08:04:53 -08:00
Matt Huszagh d9d500743f simplify atan initial angle expression 2020-12-17 08:02:54 -08:00
Matt Huszagh 2ddaab8fae dsp: fix bench import path 2020-12-16 16:57:18 -08:00
Matt Huszagh 85ae70fe62 rename trig tests to delineate between cossin and atan2 2020-12-16 16:28:49 -08:00
Matt Huszagh 7c4f608206 move cossin and atan2 into the same trig file 2020-12-16 16:26:44 -08:00
Matt Huszagh e257545321 fix formatting 2020-12-16 16:14:11 -08:00
Matt Huszagh 5d055b01a0 dsp: add atan2 2020-12-16 16:02:42 -08:00
Matt Huszagh 6d651da758 dsp: add f64 isclose testing function 2020-12-16 16:02:17 -08:00
Matt Huszagh 17f9f0750e dsp: move abs to lib.rs 2020-12-16 16:01:50 -08:00
Matt Huszagh e89db65722 rename trig.rs -> cossin.rs 2020-12-16 15:57:47 -08:00
Ryan Summers fc81f3d55d Removing DMA support from DI0 timestamping 2020-12-15 14:34:14 +01:00
Ryan Summers 352884ea06 Fixing pounder timestamps after manual testing 2020-12-15 13:13:05 +01:00
bors[bot] a71f790574
Merge #205
205: pll: refine gains r=jordens a=jordens

this decouples frequency and phase gain

Co-authored-by: Robert Jördens <rj@quartiq.de>
2020-12-15 11:19:34 +00:00
Robert Jördens 469c89ea70 pll: refine gains 2020-12-14 09:58:27 +01:00
bors[bot] 1425608647
Merge #202
202: Fix/rj misc r=jordens a=jordens



Co-authored-by: Robert Jördens <rj@quartiq.de>
2020-12-13 12:26:14 +00:00
Robert Jördens 75c4120258 cossin: buffer test data output 2020-12-13 13:24:28 +01:00
Robert Jördens 4fc1f4397e gha: upload only relevant 2020-12-13 13:24:28 +01:00
Sebastien Bourdeauducq 107a4ac96f update cargosha256 2020-12-12 16:33:37 +08:00
bors[bot] 9a0e47c7eb
Merge #201
201: cossin bench: be fair to glibc r=jordens a=jordens



Co-authored-by: Robert Jördens <rj@quartiq.de>
2020-12-11 18:21:31 +00:00
Robert Jördens d271dccaba cossin bench: be fair to glibc 2020-12-11 19:08:11 +01:00
bors[bot] e3ab2b2db5
Merge #200
200: dsp: add host benchmark r=jordens a=jordens



Co-authored-by: Robert Jördens <rj@quartiq.de>
2020-12-11 17:35:30 +00:00
Robert Jördens f8b121600e gha: add rust to artifact name 2020-12-11 18:34:42 +01:00
Robert Jördens 193b8e2228 gha: upload-artifacts@v2 2020-12-11 18:22:16 +01:00
Robert Jördens 3b7d90fb45 gha: artifact tweak 2020-12-11 18:07:15 +01:00
Robert Jördens 028ff3847d upload artifacts 2020-12-11 17:36:10 +01:00
Robert Jördens a70110d8cc gha: fix artifact 2020-12-11 17:27:02 +01:00
Robert Jördens d4fceea5d1 cossin: bench against (i32 as f32).sin_cos() 2020-12-11 17:26:50 +01:00
Robert Jördens 5cd93d3318 fmt 2020-12-11 17:08:16 +01:00
Robert Jördens a709ab171e gha: fix bors 2020-12-11 17:06:07 +01:00
Robert Jördens 4fbd729cb4 gha: fix toolchain components 2020-12-11 17:04:34 +01:00
Robert Jördens a85738a651 dsp: add host benchmark 2020-12-11 15:19:13 +01:00