ychenfo commented on pull request M-Labs/nac3#310
nac3core: add fields initialization check for parent classThis looks good to me! The only thing that might be of a bit concern is that this deviates from python's original semantic, under which the following code would give an error. But I think the…
ychenfo commented on issue M-Labs/nac3#275
Random segmentation faults on running artiq_sinara_testerIt's a bit weird but this line of setting up the population pass seems to be the cause of the problem: https://git.m-labs.hk/M-Labs/nac3/src/commit/8e6e4d6715bdfa4a5639068e4a78e89b714fb8d7/nac3core…
ychenfo deleted branch fix-call-param-type from M-Labs/nac3
ychenfo pushed to fix-call-param-type at ychenfo/nac3
- a32faf78d2 nac3standalone: add more tests
- d568161169 nac3core: fix codegen error of inheritance
- 6e578a2ebd nac3core: codegen fix call parameter type error
- 4c39dd240f update all dependencies
- 48fc5ceb8e nac3artiq: demote global value to private
- Compare 8 commits »
ychenfo created pull request M-Labs/nac3#295
Fix Call Type Error of Inheritanceychenfo created pull request M-Labs/nac3#294
Codegen Fix Call Parameter Type Errorychenfo pushed to 290-fix-inheritance-arg-err at M-Labs/nac3
- 8addf2b55e nac3standalone: add more tests
- 5d5e9a5e02 nac3core: fix codegen error of inheritance
- Compare 2 commits »
ychenfo pushed to fix-call-param-type at M-Labs/nac3
- a32faf78d2 nac3standalone: add more tests
- d568161169 nac3core: fix codegen error of inheritance
- 6e578a2ebd nac3core: codegen fix call parameter type error
- Compare 3 commits »
ychenfo commented on pull request M-Labs/nac3#293
LLVM Call Parameter Mismatch FixAh actually there seems no need to precisely restore the previous llvm module, creating a new empty one just to collect errors should be enough.
ychenfo commented on pull request M-Labs/nac3#293
LLVM Call Parameter Mismatch FixThis PR closed to be separates into to 2
ychenfo closed pull request M-Labs/nac3#293
LLVM Call Parameter Mismatch Fixychenfo commented on pull request M-Labs/nac3#293
LLVM Call Parameter Mismatch FixThanks for pointing this out! I just run some benchmark and this is indeed significantly slowing things down, as shown below. I will look into this. python porgram from 10 to 150 functions (50 loc…
ychenfo created pull request M-Labs/nac3#293
LLVM Call Parameter Mismatch Fixychenfo pushed to fix-call-param-type at M-Labs/nac3
- 0966adca74 nac3standalone: add more tests
ychenfo pushed to fix-call-param-type at M-Labs/nac3
- 8edcb226a5 nac3core: fix codegen error of inheritance
ychenfo pushed to fix-call-param-type at M-Labs/nac3
- 5f04f75648 nac3core: fix codegen error of inheritance