• Joined on 2021-03-29
ychenfo commented on pull request M-Labs/nac3#310 2022-08-31 19:06:12 +08:00
nac3core: add fields initialization check for parent class

This looks good to me! The only thing that might be of a bit concern is that this deviates from python's original semantic, under which the following code would give an error.

But I think the…

ychenfo commented on issue M-Labs/nac3#275 2022-06-07 03:12:54 +08:00
Random segmentation faults on running artiq_sinara_tester

It's a bit weird but this line of setting up the population pass seems to be the cause of the problem: 8e6e4d6715/nac3core

ychenfo deleted branch fix-call-param-type from M-Labs/nac3 2022-06-01 19:12:13 +08:00
ychenfo created branch fix-call-param-type in ychenfo/nac3 2022-06-01 18:16:08 +08:00
ychenfo pushed to fix-call-param-type at ychenfo/nac3 2022-06-01 18:16:08 +08:00
a32faf78d2 nac3standalone: add more tests
d568161169 nac3core: fix codegen error of inheritance
6e578a2ebd nac3core: codegen fix call parameter type error
4c39dd240f update all dependencies
48fc5ceb8e nac3artiq: demote global value to private
Compare 8 commits »
ychenfo created pull request M-Labs/nac3#295 2022-06-01 18:05:15 +08:00
Fix Call Type Error of Inheritance
ychenfo created pull request M-Labs/nac3#294 2022-06-01 18:00:24 +08:00
Codegen Fix Call Parameter Type Error
ychenfo created branch 290-fix-inheritance-arg-err in M-Labs/nac3 2022-06-01 17:58:21 +08:00
ychenfo pushed to 290-fix-inheritance-arg-err at M-Labs/nac3 2022-06-01 17:58:21 +08:00
8addf2b55e nac3standalone: add more tests
5d5e9a5e02 nac3core: fix codegen error of inheritance
Compare 2 commits »
ychenfo created branch 276-fix-arg-type-err in M-Labs/nac3 2022-06-01 17:57:21 +08:00
ychenfo pushed to 276-fix-arg-type-err at M-Labs/nac3 2022-06-01 17:57:21 +08:00
ychenfo pushed to fix-call-param-type at M-Labs/nac3 2022-06-01 17:55:07 +08:00
a32faf78d2 nac3standalone: add more tests
d568161169 nac3core: fix codegen error of inheritance
6e578a2ebd nac3core: codegen fix call parameter type error
Compare 3 commits »
ychenfo commented on pull request M-Labs/nac3#293 2022-06-01 17:53:48 +08:00
LLVM Call Parameter Mismatch Fix

Ah actually there seems no need to precisely restore the previous llvm module, creating a new empty one just to collect errors should be enough.

ychenfo commented on pull request M-Labs/nac3#293 2022-06-01 17:29:47 +08:00
LLVM Call Parameter Mismatch Fix

This PR closed to be separates into to 2

ychenfo closed pull request M-Labs/nac3#293 2022-06-01 17:28:42 +08:00
LLVM Call Parameter Mismatch Fix
ychenfo commented on pull request M-Labs/nac3#293 2022-06-01 17:28:00 +08:00
LLVM Call Parameter Mismatch Fix

Thanks for pointing this out! I just run some benchmark and this is indeed significantly slowing things down, as shown below. I will look into this.

python porgram from 10 to 150 functions (50 loc…

ychenfo created pull request M-Labs/nac3#293 2022-06-01 04:46:52 +08:00
LLVM Call Parameter Mismatch Fix
ychenfo pushed to fix-call-param-type at M-Labs/nac3 2022-06-01 04:27:28 +08:00
0966adca74 nac3standalone: add more tests
ychenfo pushed to fix-call-param-type at M-Labs/nac3 2022-06-01 04:16:25 +08:00
8edcb226a5 nac3core: fix codegen error of inheritance
ychenfo pushed to fix-call-param-type at M-Labs/nac3 2022-06-01 03:48:35 +08:00
5f04f75648 nac3core: fix codegen error of inheritance