nac3core: add fields initialization check for parent class #310

z78078 · 2022-08-17T17:46:24+08:00

z78078 commented

2022-08-17 17:46:24 +08:00

Field initialization checks for case below would be available.

class Foo:
    x: int32
    z: int32

    def __init__(self,):
        self.x = 42
        self.z = 43


class Bar(Foo):
    y: int32

    def __init__(self,):
        self.y = 41


class Baz(Bar):
    def __init__(self,):
        pass


def run() -> int32:
    b = Bar()
    return 0

Field initialization checks for case below would be available. ``` class Foo: x: int32 z: int32 def __init__(self,): self.x = 42 self.z = 43 class Bar(Foo): y: int32 def __init__(self,): self.y = 41 class Baz(Bar): def __init__(self,): pass def run() -> int32: b = Bar() return 0 ```

z78078 added 1 commit 2022-08-17 17:46:24 +08:00

74b9416174 nac3core: add fields initialization check for parent class

sb10q requested review from ychenfo 2022-08-24 16:59:22 +08:00

ychenfo commented

2022-08-31 19:06:12 +08:00

This looks good to me! The only thing that might be of a bit concern is that this deviates from python's original semantic, under which the following code would give an error.

But I think the python's original semantic is due to its dynamic nature, in nac3 we are doing things more statically so this should be fine if our users are aware of the behavior of nac3.

class A:
	def __init__(self):
    	self.a = 4
class B(A):
	def __init__(self):
    	self.b = 5

b = B()
b.a      # error: has no attribute 'a'

This looks good to me! The only thing that might be of a bit concern is that this deviates from python's original semantic, under which the following code would give an error. But I think the python's original semantic is due to its dynamic nature, in nac3 we are doing things more statically so this should be fine if our users are aware of the behavior of nac3. ```python class A: def __init__(self): self.a = 4 class B(A): def __init__(self): self.b = 5 b = B() b.a # error: has no attribute 'a' ```

This pull request has changes conflicting with the target branch.