M-Labs
/
nac3
8
0
Fork 5
Code Issues 87 Pull Requests 3 Releases Wiki Activity

Fix Call Type Error of Inheritance #295

Merged
sb10q merged 2 commits from 290-fix-inheritance-arg-err into master 2022-06-01 20:09:55 +08:00
Conversation 0 Commits 2 Files Changed 4
ychenfo commented 2022-06-01 18:05:15 +08:00
Collaborator

This PR is separated from #293, and fixes #290

In artiq, in nac3devices.py there are already cases like this (class Zotino and AD53xx), but that error which should be exposed is masked since the child class Zotino does not have any more data members. The sample code in #293 will cause the error since the child class has on more fields.

This PR is separated from #293, and fixes #290 --- In artiq, in `nac3devices.py` there are already cases like this (class `Zotino` and `AD53xx`), but that error which should be exposed is masked since the child class `Zotino` does not have any more data members. The sample code in #293 will cause the error since the child class has on more fields.
ychenfo added 2 commits 2022-06-01 18:05:16 +08:00
sb10q merged commit 8addf2b55e into master 2022-06-01 20:09:55 +08:00
sb10q deleted branch 290-fix-inheritance-arg-err 2022-06-01 20:09:57 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
UROP0622
   
future-extension
   
high-priority
   
low-priority
No Label
UROP0622
future-extension
high-priority
low-priority
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#295
There is no content yet.
Delete Branch "290-fix-inheritance-arg-err"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?