The changes to the software will be cleaned up and submitted for a pull request on sat.
@topquark12 Did you merge the changes you mentioned?
Did you try out the PID selection algorithm using your test setup? #32
Looks like a nice setup. And that's a good result for stability. Definitely better than what I've seen in my own setup. I typically see 100 mK noise and several 100 mK temperature offset from set…
If you insist on using the /modern standard/ please update the documentation so the 99% solution is obvious. Something like the following would be helpful.
https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing doesn't mention /L so I guess it's not that prevalent. I think what you mean is /24 for conventional subnet with mask 255.255.255.0.
Also, <X.X.X.X/L> syntax isn't used elsewhere in Sinara/ARTIQ as far as I've seen.
I was using latest firmware... I built it.
I'm not my test bench at the moment. Did you update pytec to ingest the new JSON?
A toy setup would be helpful at firmware validation. Basically, helps at finding bugs before end-users do. Examples...
- does documented dt permit application of Ziegler Nichols approach at PID…
ipv4 <X.X.X.X/L> [Y.Y.Y.Y] Configure IPv4 address, netmask length, and optional default gateway
I doubt 99% of users are going to care about setting netmask length or custom gateway. How…
Please add check for status response and simple exception handling to pytec client.