ipv4 192.168.1.52 "invalid input" #29

New Issue

jbqubit · 2020-12-19T03:13:30+08:00

jbqubit commented

2020-12-19 03:13:30 +08:00

With latest firmware that builds.

Connection to 192.168.1.26 23 port [tcp/telnet] succeeded!
ipv4 192.168.1.52
{ "error": "invalid input" }

With latest firmware that builds. ```$ nc -vv 192.168.1.26 23 Connection to 192.168.1.26 23 port [tcp/telnet] succeeded! ipv4 192.168.1.52 { "error": "invalid input" } ```

astro commented

2020-12-19 04:24:17 +08:00

Yes. Now with sufficient configuration storage in flash, you get to specify the subnet mask length, and the default gateway!

As reflected in README.md:
ipv4 <X.X.X.X/L> [Y.Y.Y.Y]

This is now immediately written to flash. The config/save commands deal only with channel parameters.

Yes. Now with sufficient configuration storage in flash, you get to specify the subnet mask length, and the default gateway! As reflected in README.md: `ipv4 <X.X.X.X/L> [Y.Y.Y.Y]` This is now immediately written to flash. The `config`/`save` commands deal only with channel parameters.

astro closed this issue

2020-12-19 04:24:17 +08:00

jbqubit commented

2020-12-20 02:05:08 +08:00

ipv4 <X.X.X.X/L> [Y.Y.Y.Y] Configure IPv4 address, netmask length, and optional default gateway

I doubt 99% of users are going to care about setting netmask length or custom gateway. How about
ipv4 <X.X.X.X> [Y.Y.Y.Y Z.Z.Z.Z] where X is IP, Y is netmask and Z is gateway. That way simple things remain simple.

```ipv4 <X.X.X.X/L> [Y.Y.Y.Y] Configure IPv4 address, netmask length, and optional default gateway``` I doubt 99% of users are going to care about setting netmask length or custom gateway. How about ```ipv4 <X.X.X.X> [Y.Y.Y.Y Z.Z.Z.Z]``` where X is IP, Y is netmask and Z is gateway. That way simple things remain simple.

sb10q commented

2020-12-20 10:44:11 +08:00

Where is the default gateway used anyway? Though we might need it if we add MQTT.

jbqubit commented

2020-12-21 04:28:38 +08:00

Also, <X.X.X.X/L> syntax isn't used elsewhere in Sinara/ARTIQ as far as I've seen.

Also, ```<X.X.X.X/L>``` syntax isn't used elsewhere in Sinara/ARTIQ as far as I've seen.

astro commented

2020-12-22 08:16:40 +08:00

<X.X.X.X/L> (CIDR) is the modern standard way of expressing a network interface address. This new shape of IPv4 configuration is supposed to be much more intuitive because it looks like on every other device.

`<X.X.X.X/L>` (*CIDR*) is the modern standard way of expressing a network interface address. This new shape of IPv4 configuration is supposed to be much more intuitive because it looks like on every other device.

jbqubit commented

2020-12-22 22:33:40 +08:00

https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing doesn't mention /L so I guess it's not that prevalent. I think what you mean is /24 for conventional subnet with mask 255.255.255.0.

astro commented

2020-12-23 22:21:33 +08:00

where L is in the range 0..=32

jbqubit commented

2020-12-24 00:03:27 +08:00

If you insist on using the /modern standard/ please update the documentation so the 99% solution is obvious. Something like the following would be helpful.

Set IPv4 address and netmask, following the [CIDR](https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing) notation, and optional default gateway. A common CIDR is X.X.X.X/24 which corresponds to the 255.255.255.0 subnet mask.

If you insist on using the /modern standard/ please update the documentation so the 99% solution is obvious. Something like the following would be helpful. ```Set IPv4 address and netmask, following the [CIDR](https://en.wikipedia.org/wiki/Classless_Inter-Domain_Routing) notation, and optional default gateway. A common CIDR is X.X.X.X/24 which corresponds to the 255.255.255.0 subnet mask.```

Sign in to join this conversation.

No Label

No Milestone

No Assignees

3 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#29