M-Labs
/
thermostat
9
0
Fork 5
Code Issues 8 Pull Requests 14 Releases Wiki Activity

get vs set command nomenclature, eg report? #28

New Issue
Closed
opened 2020-12-19 01:19:44 +08:00 by jbqubit · 1 comment
jbqubit commented 2020-12-19 01:19:44 +08:00
Contributor
Copy Link

The current nomenclature for getting status of thermostat is a command with no arguments while setting is command with arguments. This obviously works but wasn't initially obvious to me when I started working with Thermostat. I've seen it's common in serial interfaces to append ? to get requests. For example report? and pwm?. I don't feel strongly about this. Just a suggestion.

The current nomenclature for getting status of thermostat is a command with no arguments while setting is command with arguments. This obviously works but wasn't initially obvious to me when I started working with Thermostat. I've seen it's common in serial interfaces to append ``?`` to get requests. For example ``report?`` and ``pwm?``. I don't feel strongly about this. Just a suggestion.
astro commented 2020-12-21 04:06:05 +08:00
Copy Link

I did not want users to have to learn different syntaxes for getting and setting configuration. Therefore commands without parameters yield information quickly.

I did not want users to have to learn different syntaxes for getting and setting configuration. Therefore commands without parameters yield information quickly.
astro closed this issue 2020-12-21 04:06:14 +08:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
dev-gui
GUI
softspi
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#28
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?