M-Labs
/
zynq-rs
10
0
Fork 12
Code Issues 6 Pull Requests 1 Releases Wiki Activity

Red Pitaya DDR temporary fix #69

Merged
sb10q merged 1 commits from pca006132/zynq-rs:redpitaya into master 2020-09-26 17:04:38 +08:00
Conversation 0 Commits 1 Files Changed 3
pca006132 commented 2020-09-26 16:36:34 +08:00

Temporary fix for #67 by applying a subset of ps7_init data related to DDR for DDR initialization.

The current driver is a bit messy with ad hoc parameter settings for different models spread all over the code. Adding support for red pitaya may require changing quite a lot of code. (~30 registers) Also, it seems that the ps7_init data is a bit different from the value calculated from the datasheet and TRM instruction, so it may require some testing later to see if we should adopt which. I currently don't have enough time for doing that so I would just apply the ps7_init first.

A long term solution may require refactoring of the DDR module for specifying different parameters for different models, which may take a long term to do so.
I am thinking if it would be reasonable to generate that from ps7_init data. We can just write a simple parser to parse the ps7_init data, which the parameters are proved to be working, and we don't have to aggregate data from the datasheets manually which is a pain. However, that approach may not work for custom boards.

Temporary fix for #67 by applying a subset of ps7_init data related to DDR for DDR initialization. The current driver is a bit messy with ad hoc parameter settings for different models spread all over the code. Adding support for red pitaya may require changing quite a lot of code. (~30 registers) Also, it seems that the ps7_init data is a bit different from the value calculated from the datasheet and TRM instruction, so it may require some testing later to see if we should adopt which. I currently don't have enough time for doing that so I would just apply the ps7_init first. A long term solution may require refactoring of the DDR module for specifying different parameters for different models, which may take a long term to do so. I am thinking if it would be reasonable to generate that from ps7_init data. We can just write a simple parser to parse the ps7_init data, which the parameters are proved to be working, and we don't have to aggregate data from the datasheets manually which is a pain. However, that approach may not work for custom boards.
sb10q closed this pull request 2020-09-26 17:04:38 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/zynq-rs#69
There is no content yet.
Delete Branch "pca006132/zynq-rs:redpitaya"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?