M-Labs
/
zynq-rs
10
0
Fork 12
Code Issues 6 Pull Requests 1 Releases Wiki Activity

TcpStream.recv(): wrap callback in RefCell to allow FnMut #50

Closed
astro wants to merge 1 commits from tcp-recv-fnmut into master
pull from: tcp-recv-fnmut
merge into: M-Labs:master
Conversation 1 Commits 1 Files Changed 1
astro commented 2020-07-24 01:01:35 +08:00

No unsafe but I'm not 100% certain of any repercussions. artiq-zynq seems to work.

No `unsafe` but I'm not 100% certain of any repercussions. artiq-zynq seems to work.
sb10q commented 2020-07-24 09:49:44 +08:00
Owner

I'm already using RefCell in one place, and could write the code without it in other places. I don't think we need RefCell systematically. Closing for now.

I'm already using RefCell in one place, and could write the code without it in other places. I don't think we need RefCell systematically. Closing for now.
sb10q closed this pull request 2020-07-24 09:49:47 +08:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/zynq-rs#50
There is no content yet.
Delete Branch "tcp-recv-fnmut"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?