201ec1dd7f
Update inverse.rs - improved code doc try_inverse_mut
...
The "and leaves `self` untouched" part of the code doc was wrong. Self may be modified before early false return.
2024-05-23 09:50:21 +02:00
afc03cc403
Merge pull request #1384 from jnyfah/dev
...
Inverting a 4x4 matrix with `try_inverse_mut` doesn't leave `self` unchanged if the inversion fails.
2024-05-05 12:04:49 +02:00
9bc7f8b0d8
Merge pull request #1383 from derchr/column-major-fix
...
Fix false row-major comment in doc
2024-04-30 14:22:19 +02:00
5e8779957e
missed one cofactor
2024-04-28 16:02:46 +00:00
e84ea21c74
Fixed a typo in documentation in matrix_view.rs
2024-04-22 19:51:49 -07:00
c21df4e1a3
remove else
2024-04-22 19:00:44 +00:00
a0da49fb83
early return
2024-04-22 12:36:35 +00:00
d331bbd7c1
inversion
2024-04-19 14:49:14 +00:00
28d04b61cd
Fix false row-major comment in doc
...
In the documentation of RawStorage::stride it was falsely claimed that
the storage of the matrix happens in a row-major fashion. In fact it is
column-major.
2024-04-18 18:07:21 +02:00
c475c4000c
Fix numerical issue on SVD with near-identity matrix ( #1369 )
...
* fix: Normalize the column once more
The column may not be normalized if the `factor` is on a scale of 1e-40.
Possibly, f32 just runs out of precision.
There is likely a better solution to the problem.
* chore: Add test that fails before fix
* chore: add comment providing details on the householder fix.
* chore: rename regression test
---------
Co-authored-by: Sébastien Crozet <sebcrozet@dimforge.com>
2024-03-28 15:26:11 +01:00
749a9fee17
Merge pull request #1317 from yotamofek/swap-unchecked-ub
...
Fix UB in `RawStorageMut::swap_unchecked_linear`
2024-03-27 20:44:39 -04:00
1cfc539a96
Fix type inference error in tests on rustc beta
2024-03-22 12:36:59 -07:00
095c561b60
Apply suggestions from code review
...
Co-authored-by: tpdickso <terence.dickson.prf@gmail.com>
2024-03-20 19:55:03 +02:00
d1b5df480f
Merge branch 'dev' of https://github.com/dimforge/nalgebra into swap-unchecked-ub
2024-03-20 16:37:44 +00:00
d884a7e2d0
fmt
2024-03-19 16:39:28 +00:00
546d06b541
Update src/base/storage.rs
...
Co-authored-by: tpdickso <terence.dickson.prf@gmail.com>
2024-03-19 16:39:28 +00:00
adc3a8103b
Fix UB in `RawStorageMut::swap_unchecked_linear`
2024-03-19 16:39:28 +00:00
bbac38b2f5
Support Glam 0.25 type conversion
2024-01-27 21:11:47 +02:00
7866bcee5c
Remove CUDA support relying on abandoned toolchain
2024-01-11 23:09:17 -08:00
a60870daf6
docs: Demonstrate correct function in to_homogeneous example ( #1346 )
2024-01-04 19:21:40 -08:00
6dce471297
Make OPoint call `T::fmt` to respect formatting modifiers ( #1336 )
2023-12-20 14:42:54 -08:00
1e0cb7bc09
Fix Clippy Warnings ( #1300 )
2023-12-16 13:54:38 -08:00
c3fe38b318
docs: Fix unbalanced backticks.
2023-12-10 14:04:53 -08:00
a91e3b0d89
Merge pull request #1315 from yotamofek/owned-view-iter
...
Allow creating matrix iter with an owned view
2023-11-12 23:29:41 +01:00
83eccc6b8f
Merge pull request #1312 from arscisca/dev-DefaultTrait
...
Implement Default trait for sparse matrix types
2023-11-12 23:27:37 +01:00
06b8d38970
fix no-std builds.
2023-11-12 23:17:17 +01:00
469390f4b9
Check norm_squared instead of mangnitude.
2023-11-12 23:12:52 +01:00
1195eadd1a
Allow creating matrix iter with an owned view
2023-11-12 08:19:29 +00:00
7ea9ecee08
Test for axes with zero magnitude
2023-11-09 01:20:44 +01:00
b6e094c82f
Fix spelling in givens.rs
2023-11-09 00:48:13 +01:00
0887b875a5
Implement Default trait for sparse matrix types
2023-10-30 17:50:56 +00:00
c6ff3eeb7e
Merge pull request #1265 from waywardmonkeys/fix-html-links
...
docs: Use intradoc links rather than HTML.
2023-09-30 18:24:28 +02:00
804e606c97
Merge pull request #1270 from waywardmonkeys/look-at-lh-is-left-handed
...
doc: Isometry's `look_at_lh` is left-handed.
2023-09-30 18:21:48 +02:00
1987ca29bb
Merge pull request #1282 from waywardmonkeys/clippy-needless-borrow
...
clippy: Fix needless_borrow warnings.
2023-09-30 18:15:42 +02:00
5a9d036226
Merge pull request #1283 from waywardmonkeys/dual-quaternion-wrong-self-convention
...
DualQuaternion: Fix to_vector self convention.
2023-09-30 18:13:23 +02:00
87796ace42
DOC: Use norm_squared() in its doctest
2023-09-30 13:01:11 +02:00
bfb84e8fc6
DualQuaternion: Fix to_vector self convention.
...
By taking a ref, we can avoid an extra copy on the caller side.
2023-08-19 00:52:59 +07:00
1d9a4bf6ec
clippy: Fix needless_borrow warnings.
2023-08-19 00:36:24 +07:00
f404bcbd6d
Merge pull request #1279 from waywardmonkeys/clippy-less-lazy
...
clippy: Don't need lazy eval for len calls.
2023-08-15 11:01:13 +02:00
cb2ed212ed
clippy: Don't need lazy eval for len calls.
2023-08-15 14:46:35 +07:00
76866ad878
clippy: Fix needless_return warnings.
2023-08-15 14:34:34 +07:00
6ac9d8995c
Merge pull request #1276 from waywardmonkeys/fix-rkyv-feature-doc-warnings
...
docs: Fix 2 warnings when building with rkyv.
2023-08-15 09:19:07 +02:00
226761323f
docs: Fix 2 warnings when building with rkyv.
2023-08-14 17:23:59 +07:00
a2fd72dfb9
`split_at` is only used by Rayon code.
...
This fixes an unused code warning. Since the code is `pub(crate)`,
it was only available within the crate and only used by Rayon
code, so it is no functional change to not compile it except
when the right feature is enabled.
Also, fix a minor typo in some non-doc comments.
2023-08-14 17:21:45 +07:00
8d7763ab8f
Merge pull request #1275 from waywardmonkeys/no-default-features-unused-import-warnings
...
Fix import warnings when `--no-default-features`.
2023-08-14 08:57:45 +02:00
69b46cb7fa
Merge pull request #1260 from WarrenWeckesser/use-assert-macro
...
DOC: Fix compiler warning in the first example in lib.rs.
2023-08-14 08:53:24 +02:00
ec9a88c0ac
Merge pull request #1271 from waywardmonkeys/incorrect-usages-of-relative-eq
...
Use `assert_relative_eq!` instead of relative_eq!`.
2023-08-14 08:51:22 +02:00
3fdeeca09c
Merge pull request #1272 from waywardmonkeys/unused-lifetimes
...
clippy: Remove unused lifetimes.
2023-08-14 08:36:50 +02:00
14b00f6bf6
Fix import warnings when `--no-default-features`.
2023-08-14 11:40:03 +07:00
a51886ed3f
clippy: Remove unused lifetimes.
2023-08-14 09:21:56 +07:00
Pavel Kučera
Andreas Borgen Longva
Jennifer Chukwu
Adrian H
Derek Christ
Vollkornaffe
tpdickso
Yotam Ofek
Joona Aalto
Benjamin Saunders
Benjamin De Roeck
Kurt Lawrence
Julian Knodt
Bruce Mitchener
Sébastien Crozet
Rasmus Brönnegård
Alessandro Rocco Scisca
Matthias Geier