M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 99 Pull Requests 21 Releases Wiki Activity

Implement several unimplemented integer operations and fix casting-related bugs #353

Merged
sb10q merged 1 commits from fix/int-ops-and-casting into master 2024-08-17 17:37:20 +08:00
Conversation 0 Commits 1 Files Changed 1 +184
derppening commented 2023-11-03 16:27:46 +08:00
Collaborator
Copy Link
  • Implemented and fixed bitwise-not for integers
  • Fixed missing wrap-around behavior for float-to-int32 and float-to-unsigned conversions
  • Fixed missing sign extension for int32-to-uint64
  • Added regression test for numeric conversions
- Implemented and fixed bitwise-not for integers - Fixed missing wrap-around behavior for float-to-int32 and float-to-unsigned conversions - Fixed missing sign extension for int32-to-uint64 - Added regression test for numeric conversions
derppening added 6 commits 2023-11-03 16:27:47 +08:00
7a5a2db842 core: Fix handling of float-to-int32 casts 
Out-of-bound conversions should be wrapped around.
8ad09748d0 core: Fix conversion from float to unsigned types 
These conversions also need to wraparound.
c6b9aefe00 core: Fix int32-to-uint64 conversion 
This conversion should be sign-extended.
derppening self-assigned this 2023-11-03 16:27:55 +08:00
derppening requested review from sb10q 2023-11-03 16:28:02 +08:00
sb10q merged commit 9d737743c1 into master 2023-11-04 13:28:29 +08:00
sb10q deleted branch fix/int-ops-and-casting 2023-11-04 13:28:30 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
sb10q
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
derppening
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#353
No description provided.
Delete Branch "fix/int-ops-and-casting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?