Implement several unimplemented integer operations and fix casting-related bugs #353

derppening · 2023-11-03T16:27:46+08:00

derppening commented

2023-11-03 16:27:46 +08:00

Implemented and fixed bitwise-not for integers
Fixed missing wrap-around behavior for float-to-int32 and float-to-unsigned conversions
Fixed missing sign extension for int32-to-uint64
Added regression test for numeric conversions

- Implemented and fixed bitwise-not for integers - Fixed missing wrap-around behavior for float-to-int32 and float-to-unsigned conversions - Fixed missing sign extension for int32-to-uint64 - Added regression test for numeric conversions

derppening added 6 commits 2023-11-03 16:27:47 +08:00

92d6f0a5d3 core: Implement bitwise not for unsigned ints and fix implementation

447eb9c387 standalone: Fix output format string for output_uint*

7a5a2db842 core: Fix handling of float-to-int32 casts

Out-of-bound conversions should be wrapped around.

8ad09748d0 core: Fix conversion from float to unsigned types

These conversions also need to wraparound.

c6b9aefe00 core: Fix int32-to-uint64 conversion

This conversion should be sign-extended.

9d737743c1 standalone: Add regression test for numeric primitive operations

derppening self-assigned this 2023-11-03 16:27:55 +08:00

derppening requested review from sb10q 2023-11-03 16:28:02 +08:00

derppening referenced this pull request

2023-11-03 16:28:21 +08:00

Revert removal of round and round64 #352

sb10q merged commit 9d737743c1 into master

2023-11-04 13:28:29 +08:00

sb10q deleted branch fix/int-ops-and-casting

2023-11-04 13:28:30 +08:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#353