Revert removal of round and round64 #352

derppening · 2023-11-02T14:57:15+08:00

derppening commented

2023-11-02 14:57:15 +08:00

Change round/floor/ceil/trunc to return int and add *64 family which returns int64.

Change `round`/`floor`/`ceil`/`trunc` to return int and add `*64` family which returns `int64`.

derppening self-assigned this 2023-11-02 14:57:15 +08:00

derppening added 2 commits 2023-11-02 14:57:15 +08:00

e3e874c54c core: Replace rint implementation with LLVM intrinsic

2b3bf4d5ac core: Revert removal of {round,round64}

These functions are intrinsic to ARTIQ.

derppening force-pushed issue-149 from 2b3bf4d5ac to d13cfd46ab

2023-11-02 15:26:40 +08:00

Compare

derppening commented

2023-11-02 15:27:22 +08:00

Poster

v2: Add implementation for trunc64.

v2: Add implementation for `trunc64`.

sb10q commented

2023-11-02 18:41:59 +08:00

Add implementation for trunc64.

As discussed I don't think we want trunc functions, just typecast instead. In Python and Numpy, the casts already truncate:

>>> int(3.6)
3
>>> import numpy as np
>>> np.int32(3.6)
3
>>> np.int64(3.6)
3

I think numpy has this trunc function solely to be able to deal with arrays (i.e. element-wise trunc of an array). Maybe add it later when we implement numpy arrays, if it is the best solution.

> Add implementation for trunc64. As discussed I don't think we want trunc functions, just typecast instead. In Python and Numpy, the casts already truncate: ``` >>> int(3.6) 3 >>> import numpy as np >>> np.int32(3.6) 3 >>> np.int64(3.6) 3 ``` I think numpy has this trunc function solely to be able to deal with arrays (i.e. element-wise trunc of an array). Maybe add it later when we implement numpy arrays, if it is the best solution.

derppening force-pushed issue-149 from d13cfd46ab to 742b264911

2023-11-03 15:58:05 +08:00

Compare

derppening commented

2023-11-03 15:58:31 +08:00

Poster

v3: Removed trunc, fixed multiple bugs related to numeric casting

v3: Removed `trunc`, fixed multiple bugs related to numeric casting

derppening commented

2023-11-03 16:23:46 +08:00

Poster

Actually don't merge this yet, let me break the casting changes out of this PR.