• Joined on 2019-03-28
Loading Heatmap…

sb10q commented on pull request M-Labs/artiq-zynq#282

Kasli-soc: add WRPLL clock recovery

Wouldn't it be better to just wait for the CDR lock then? When is select_recovered_clock() called?

2024-03-26 15:40:01 +08:00

sb10q commented on pull request M-Labs/artiq-zynq#282

Kasli-soc: add WRPLL clock recovery

MHz

2024-03-26 15:35:03 +08:00

sb10q commented on pull request M-Labs/artiq-zynq#282

Kasli-soc: add WRPLL clock recovery

That's 20 seconds, not "a couple".

2024-03-26 15:34:16 +08:00

sb10q commented on pull request M-Labs/artiq-zynq#282

Kasli-soc: add WRPLL clock recovery

Why do we need all those mutexes? Only one thread is accessing those, no?

2024-03-26 15:31:28 +08:00

sb10q commented on pull request M-Labs/artiq-zynq#282

Kasli-soc: add WRPLL clock recovery

Wording of messages and code comments could be improved.

2024-03-26 15:27:41 +08:00

sb10q commented on pull request M-Labs/artiq-zynq#282

Kasli-soc: add WRPLL clock recovery

Writing 0 is superfluous if you use CSR() in the core.

2024-03-26 15:26:50 +08:00

sb10q commented on pull request M-Labs/artiq-zynq#282

Kasli-soc: add WRPLL clock recovery

This test can only be done after the transaction is completed and seems misplaced. Should be right after the while loop I guess, and the core should probably reset the nack status on stb.

2024-03-26 15:26:32 +08:00

sb10q commented on pull request M-Labs/artiq-zynq#282

Kasli-soc: add WRPLL clock recovery

On Kasli we won't have PS/PL. But this can be addressed later.

2024-03-26 15:08:41 +08:00

sb10q commented on pull request M-Labs/artiq-zynq#282

Kasli-soc: add WRPLL clock recovery

This is a poorly chosen name since there isn't a PLL or anything like it inside. Maybe just inline it anyway? It's just IBUFGDS really and some constraints that may be redundant and/or are dependent on the board.

2024-03-25 17:44:49 +08:00

sb10q merged pull request M-Labs/zynq-rs#113

Use nix format for arm gnu toolchain

2024-03-25 17:28:54 +08:00

sb10q pushed to master at M-Labs/zynq-rs

2024-03-25 17:28:48 +08:00

sb10q commented on issue M-Labs/nix-servo#1

We only need one GCC toolchain

Okay. How many toolchains do we have in total right now?

2024-03-25 16:28:12 +08:00

sb10q commented on issue M-Labs/nix-servo#1

We only need one GCC toolchain

U-Boot doesn't also need newlib?

2024-03-25 16:13:09 +08:00

sb10q pushed to master at M-Labs/nix-servo

  • 0d3f87c5bc use nix gnu toolchain format for baremetal apps

2024-03-25 16:12:21 +08:00

sb10q merged pull request M-Labs/nix-servo#53

Use nix gnu toolchain format for baremetal apps

2024-03-25 16:12:20 +08:00

sb10q commented on pull request M-Labs/nix-servo#53

Use nix gnu toolchain format for baremetal apps

Okay. Looks good - at least this code does. Can you send a similar PR in zynq-rs as well?

2024-03-25 16:12:03 +08:00

sb10q pushed to master at M-Labs/nac3

2024-03-25 14:45:40 +08:00

sb10q deleted branch refactor/sequenced-varmap from M-Labs/nac3

2024-03-25 12:44:51 +08:00

sb10q pushed to master at M-Labs/nac3

2024-03-25 12:44:46 +08:00

sb10q merged pull request M-Labs/nac3#388

Use sequenced collection for VarMap

2024-03-25 12:44:43 +08:00