M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 8
Code Issues 100 Pull Requests 20 Releases Wiki Activity

nac3core: irrt module get attribute id using name instead of hard code #164

Merged
sb10q merged 1 commits from better_get_enum_attr_id into master 2022-01-13 12:30:49 +08:00
Conversation 0 Commits 1 Files Changed 1 +6 -3
ychenfo commented 2022-01-11 17:31:39 +08:00
Collaborator
Copy Link

Previously I was unaware of this get_named_enum_kind_id function so I hard coded the id by checking the table in llvm source code. Now we get the id through the function by its name alwaysinline.

Previously I was unaware of this [get_named_enum_kind_id](https://thedan64.github.io/inkwell/inkwell/attributes/struct.Attribute.html#method.get_named_enum_kind_id) function so I hard coded the id by checking the table in llvm source code. Now we get the id through the function by its name `alwaysinline`.
ychenfo added 1 commit 2022-01-11 17:31:43 +08:00
sb10q merged commit 2579ecbd19 into master 2022-01-13 12:30:49 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#164
No description provided.
Delete Branch "better_get_enum_attr_id"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?