linuswck
/
thermostat
forked from M-Labs/thermostat
1
0
Fork 0
Code Pull Requests 2 Activity

GUI: Refactor send_command #4

Open
atse wants to merge 6 commits from gui_dev-refactor-send_command into gui_dev
pull from: gui_dev-refactor-send_command
merge into: linuswck:gui_dev
Conversation 0 Commits 6 Files Changed 2 +86 -119
atse commented 2024-08-14 16:37:39 +08:00
Collaborator
Copy Link

Refactors and simplifies the send_command function and the interface of the param_tree options.

Refactors and simplifies the `send_command` function and the interface of the param_tree options.
atse added 6 commits 2024-08-14 16:37:39 +08:00
dd83daa5d9 send_command: Remove indirect path to parameter 
The child at inner_param's childpath to the root parameter... is just
inner_param itself.
278898fad2 send_command: Switch to thermostat:set_param 
Use a `dict` to map values to thermostat parameters, which correspond to
the `set_param` parameters in the pytec client. New tag
"thermostat:set_param" used in JSON.
41abad7aa3 send_command: Remove "activater" 
Interpret commands anomalies directly in send_command instead
This pull request can be merged automatically.
You are not authorized to merge this pull request.
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b gui_dev-refactor-send_command gui_dev
git pull origin gui_dev-refactor-send_command

Step 2:

Merge the changes and update on Gitea.
git checkout gui_dev
git merge --no-ff gui_dev-refactor-send_command
git push origin gui_dev
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: linuswck/thermostat#4
No description provided.
Delete Branch "gui_dev-refactor-send_command"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?