atse/thermostat
1
0
Fork 0
forked from M-Labs/thermostat
Code Issues Pull Requests Activity
407 Commits 23 Branches 0 Tags 3.3 MiB
6dcd1b6275
Commit Graph

59 Commits

Author SHA1 Message Date
atse
6dcd1b6275 Keep i_set visible even when PID is engaged 
Since i_set is also plotted, we would also want to see its precise value
too.
 2024-07-18 18:08:39 +08:00
atse
c75c8f2da0 Remove MutexParameter 
Use the standard ListParamenter instead, and hook up UI changes
elsewhere.
 2024-07-18 18:08:39 +08:00
atse
c754dcfb18 Remove "activater" option 
Interpret commands directly in send_command
 2024-07-18 18:08:38 +08:00
atse
0b0bf26244 PID Autotune test current should only be positive 2024-07-18 18:08:38 +08:00
atse
487bf24ffe More straightforward mapping to thermostat command 
New tag "thermostat:set_param" used in JSON.
 2024-07-18 18:08:36 +08:00
atse
6372e03dff Separate tree and param changes 2024-07-18 18:08:10 +08:00
atse
dbee457c09 i -> ch 
and others
 2024-07-18 18:08:10 +08:00
atse
97c5f2a201 Remove unnessarily duplicated parameter tree 
Huge source of confusion and easy bugs!
 2024-07-18 18:08:10 +08:00
atse
fad9008707 Remove unneccessary redirection 
The child at inner_param's childpath to the root parameter... is just
inner_param.
 2024-07-18 18:08:10 +08:00
atse
bbd6774c75 Make send_command more readable 2024-07-18 18:08:10 +08:00
atse
405d40c543 Remove extra "channel" option to root parameters 
Their corresponding channel numbers are already represented with their
"value" options.
 2024-07-18 18:08:10 +08:00
atse
56655854cf Fix grammar in info box on PID Autotune failure 2024-07-18 18:08:10 +08:00
atse
37e888846b Don't say settings loaded on settings save 2024-07-18 18:08:09 +08:00
atse
301db2e003 ctrl_panel: PID Auto Tune -> PID Autotune 2024-07-18 18:08:09 +08:00
atse
f2ca607b8b ctrl_panel: Stop crushing spinboxes 
It might not be the case on some themes, but on the default Qt theme the
spinbox are a bit too short for the containing numbers. See
https://github.com/pyqtgraph/pyqtgraph/issues/701.
 2024-07-18 18:08:09 +08:00
atse
a18d6fb4d0 ctrl_panel: Approriate units for measured current 
Allow the readonly display of current to vary its SI prefix in the unit,
since as a display entry it won't have the unit adjustment problem.
 2024-07-18 18:08:09 +08:00
atse
0e39b29c5d ctrl_panel: Pin down units for editable fields 
Avoids awkward value editing
 2024-07-18 18:08:09 +08:00
atse
ce93004368 ctrl_panel: Improve postfilter description 2024-07-18 18:08:07 +08:00
atse
a57c365b8d ctrl_panel: Add tooltips 
For users' better understanding of what the parameters do
 2024-07-18 18:07:43 +08:00
atse
8ac4a32106 ctrl_panel: Refer to Parameters by concise names 
For displayed string representations, use the `title` key, or for
`ListParameter`s, use the dictionary mapping method instead.
 2024-07-16 15:08:42 +08:00
atse
493088f4a5 ctrl_panel: Config -> Settings 2024-07-16 15:08:05 +08:00
atse
2ae58b9abb Format JSON 2024-07-16 15:00:10 +08:00
atse
44bea87f03 Thermostat.disconnect -> Thermostat.end_session 
QObject already has a disconnect method, avoid overriding it.
 2024-07-10 15:56:43 +08:00
atse
271fe449ba Remove duplicated show call 
MainWindow.show() already called in coro_main
 2024-07-10 15:56:43 +08:00
atse
70db0a39eb Remove duplicated antialias config option 
Already set in live_plot_view.py
 2024-07-10 15:56:43 +08:00
atse
26c7382b1e Move GUI components and examples into folder 
For better organisation
 2024-07-10 15:56:43 +08:00
atse
c415d9de8a Use MANIFEST.in 
Allows for more accurate control over included files in pytec package
 2024-07-10 15:56:43 +08:00
atse
7069111e21 Expose frontend scripts exclusively in pytec 2024-07-10 15:56:43 +08:00
atse
1707728c3c thermostat_data_model.py -> thermostat.py 2024-07-10 15:56:34 +08:00
atse
a16d2e9a9e Follow CapWords convention for class names 
Re: PEP8
 2024-07-10 15:45:03 +08:00
atse
bc4ac43e0b Put comments in right place 2024-07-10 13:07:31 +08:00
linuswck
9acff86547 Restructure GUI Code, Improve and Fix Bugs 
- Bugs fix:
1. Params Tree user input will not get overwritten
    by incoming report thermostat_data_model.
2. PID Autotune Sampling Period is now set according to Thermostat sampling interval
3. PID Autotune won't get stuck in Fail State
4. Various types disconnection related Bugs
5. Number of Samples stored in the plot cannot be set
6. Limit the max settable output current to be 2000mA

- Improvement:
1. Params Tree settings can be changed with external json
2. Use a Tab system to show a single channel of config instead of two
3. Expose PID Autotune lookback params
4. Icon is changed to Artiq logo

- Restructure:
1. Restructure the code to follow Model-View-Delegate Design Pattern
 2024-06-06 17:34:15 +08:00
atse
8753f4a0fc Finish GUI 2024-05-08 14:49:03 +08:00
atse
9a83d6850d Remove unused as clause 2024-05-08 14:49:03 +08:00
Egor Savkin
772863f4b2 Add paramtree view, without updates 
Signed-off-by: Egor Savkin <es@m-labs.hk>

Fix signal blocker argument -atse
 2024-05-08 14:49:03 +08:00
atse
44ef2c04e3 Fix bugs, grammar, text, and refactor into class 2024-05-08 14:49:03 +08:00
atse
623011fabb Change title 2024-05-08 14:49:03 +08:00
atse
400f3a98e8 Stop polling drift 
Just waiting for the update_s doesn't take into account the time to
execute update_params, and causes time drift.
 2024-05-08 14:49:03 +08:00
atse
7dd5d15047 Remove unused 'as' clause 2024-05-08 14:49:03 +08:00
atse
65e1f4a146 Finish moving over to qasync 
Also:

* Add aioclient

The old client is synchronous and blocking, and the only way to achieve
true asynchronous IO is to create a new client that interfaces with
asyncio.

* Finish Nix Flake description and make the GUI available for `nix run`
 2024-05-08 14:49:03 +08:00
Egor Savkin
e0ce14c616 Try move from Qthreads to qasync 
Signed-off-by: Egor Savkin <es@m-labs.hk>
 2024-05-08 14:49:03 +08:00
Egor Savkin
a79679a074 Create client watcher, that would poll Thermostat for config 
Signed-off-by: Egor Savkin <es@m-labs.hk>
 2024-05-08 14:49:03 +08:00
Egor Savkin
b9acba69d3 Create basic GUI, that would connect and control thermostat's fan 
Signed-off-by: Egor Savkin <es@m-labs.hk>
 2024-05-08 14:49:03 +08:00
topquark12
b4b4ec987c add autotune 2024-05-08 14:49:03 +08:00
Egor Savkin
e3e3237d2f Emit warning when current/voltage limits are near zero 
Signed-off-by: Egor Savkin <es@m-labs.hk>
 2023-03-23 16:58:05 +08:00
topquark12
26ad2f0119 rewrite PID 
Rewrite of PID according to https://hackmd.io/IACbwcOTSt6Adj3_F9bKuw PID implementation.

To migrate:
- TEC+/- pin polarity has to be reversed.
- Some saved settings might be wiped upon flashing of new firmware, back up settings before upgrade
- Min / Max integral parameters no longer exist
- kp, ki, kd will likely need to be retuned

The software has been tested on hardware with good temperature control stability.

Reviewed-on: M-Labs/thermostat#68
Co-authored-by: topquark12 <aw@m-labs.hk>
Co-committed-by: topquark12 <aw@m-labs.hk>
 2022-02-24 20:16:47 +08:00
topquark12
a5d8661b10 main: fix handling of incomplete data received (#55) 
Reviewed-on: M-Labs/thermostat#55
Co-Authored-By: topquark12 <aw@m-labs.hk>
Co-Committed-By: topquark12 <aw@m-labs.hk>
 2021-01-29 16:18:07 +08:00
topquark12
96f52ace8b pytec: simpler default graphs in plot 2021-01-25 13:51:50 +08:00
topquark12
73dd6d9154 add PID autotune code 
Co-Authored-By: topquark12 <aw@m-labs.hk>
Co-Committed-By: topquark12 <aw@m-labs.hk>
 2021-01-06 11:02:52 +08:00
Astro
7c55e34145 pytec: remove obsolete conversions 2020-12-18 19:37:25 +01:00