M-Labs/thermostat
9
0
Fork 5
Code Issues 9 Pull Requests 5 Releases Wiki Activity

BREAKING: PID Refactor #68

Merged
sb10q merged 6 commits from pid_refactor into master 2022-02-24 20:16:47 +08:00
Conversation 1 Commits 6 Files Changed 8 +43 -116
topquark12 commented 2022-02-21 16:39:28 +08:00
Contributor
Copy Link

Rewrite of PID according to https://hackmd.io/IACbwcOTSt6Adj3_F9bKuw PID implementation.

To migrate:

  • TEC+/- pin polarity has to be reversed.
  • Some saved settings might be wiped upon flashing of new firmware, back up settings before upgrade
  • Min / Max integral parameters no longer exist
  • kp, ki, kd will likely need to be retuned

The software has been tested on hardware with good temperature control stability.

Rewrite of PID according to https://hackmd.io/IACbwcOTSt6Adj3_F9bKuw PID implementation. To migrate: - TEC+/- pin polarity has to be reversed. - Some saved settings might be wiped upon flashing of new firmware, back up settings before upgrade - Min / Max integral parameters no longer exist - kp, ki, kd will likely need to be retuned The software has been tested on hardware with good temperature control stability.
topquark12 added 6 commits 2022-02-21 16:39:29 +08:00
SingularitySurfer commented 2022-02-21 18:12:04 +08:00
Owner
Copy Link

FYI there would also be the idsp crate with implementations for the IIRs: https://github.com/quartiq/idsp

FYI there would also be the idsp crate with implementations for the IIRs: https://github.com/quartiq/idsp
sb10q merged commit 26ad2f0119 into master 2022-02-24 20:16:47 +08:00
sb10q deleted branch pid_refactor 2022-02-24 20:16:47 +08:00
sb10q referenced this issue from a commit 2022-02-24 20:16:47 +08:00
rewrite PID
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#68
No description provided.
Delete Branch "pid_refactor"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?