atse
/
thermostat
forked from M-Labs/thermostat
1
0
Fork 0
Code Issues Pull Requests Activity
441 Commits 26 Branches 0 Tags 3.2 MiB
Commit Graph

441 Commits

Author SHA1 Message Date
atse 31bdbf93c4 ================gui_dev-fix_asyncio=============== 2024-10-07 17:48:24 +08:00
atse c2952f881f Use new style super() 2024-10-07 17:48:24 +08:00
atse 810237bccf Move command line host:port setting handling 
To main
 2024-10-07 17:48:24 +08:00
atse f9b1bf8c6c aioclient: Add missing readline for saving 
Saving all channels returns multiple JSON objects, read the extra {}.
 2024-10-07 17:48:24 +08:00
atse 23aafeba08 import order rearrange 2024-10-07 17:48:24 +08:00
atse 334c4dbdce This is bail 2024-10-07 17:48:24 +08:00
atse 56b2ecfc9b thermostat: Properly register task 
Also Thermostat.task -> Thermostat._update_params_task
 2024-10-07 17:48:24 +08:00
atse de583c38c4 ip -> host 2024-10-07 17:48:24 +08:00
atse 5f69cb55e7 Lazy evaluating for debug string command 2024-10-07 17:48:24 +08:00
atse 4ccddf9f20 Add pytec runnables 2024-10-07 17:48:24 +08:00
atse 28bcdd4926 PYTHON shell 2024-10-07 17:48:24 +08:00
atse 585c33cabb Exactlier wording 2024-10-07 17:48:24 +08:00
atse 7696a07b4a unused 2024-10-07 17:48:24 +08:00
atse 2eb7eb40a2 encoding 2024-10-07 17:48:24 +08:00
atse 206b825e88 Just catch asyncio.TimeoutError 
Will just change to TimeoutError once we switch to Python 3.11 in the
flake.
 2024-10-07 17:48:24 +08:00
atse 4a038d04d1 Remove exception too general 2024-10-07 17:48:24 +08:00
atse 8599c5be4e Use asserts to check for connectivity 2024-10-07 17:48:24 +08:00
atse 99777d75ce Add back the parent 2024-10-07 17:48:24 +08:00
atse b6696c2b09 Fix method call 2024-10-07 17:48:24 +08:00
atse d9aab02456 README: Proofread 2024-10-07 17:48:24 +08:00
atse 35a447e980 Swap order arounda bit more 2024-10-07 17:48:24 +08:00
atse f19809c852 Formatting 2024-10-07 17:48:24 +08:00
atse c804c7bedb Use qtextras 2024-10-07 17:48:24 +08:00
atse 78477163fb flake update 2024-10-07 17:48:24 +08:00
atse dcc4a4578a flake.nix: nixfmt-rfc-style 2024-10-07 17:48:24 +08:00
atse a531978d96 Merge branch 'gui_dev-ctrl_panel' into newlol 2024-10-07 17:26:26 +08:00
atse c9aa0eaab8 ctrl_panel: Reformat SpinBox text always if valid 
The parameter SpinBoxes previously would only update if the interpreted
value was changed, missing cases where the text would have changed but
the value stays the same, e.g. removing trailing decimal zeros.
 2024-10-07 16:13:56 +08:00
atse ed6cee4394 ctrl_panel: Move postfilter into its own group 2024-10-07 16:13:56 +08:00
atse e1bd960900 ctrl_panel: Use new locking mechanism from Kirdy 2024-10-07 16:13:56 +08:00
atse aed0c484dd ctrl_panel: Fix editing fields with unit "°C" 
A faulty regular expression within PyQtGraph causes any Parameter with a
suffix that doesn't begin with an alphanumeric character (as matched
with \w) to act abnormally. For instance, entering "100 °C" into the
input boxes gets interpreted as 10 °C.

Patch the FLOAT_REGEX in PyQtGraph to simply match for any character in
the suffix group.
 2024-10-07 16:13:56 +08:00
atse 3fe343435d ctrl_panel: More appropriate steps and fixes 2024-10-07 16:13:56 +08:00
atse eddfc40e07 ctrl_panel: Put plotted values into readings group 
For more intuitiveness to first-time users
 2024-10-07 16:13:56 +08:00
atse 3ae89760ab ctrl_panel: Fix max_v to only have unit "V" 
As most users do not need to limit TEC voltage with accuracy of less
than 1mV.
 2024-10-07 16:13:56 +08:00
atse 2f9b95f04b ctrl_panel: Bold "Control Method" text 2024-10-07 16:13:56 +08:00
atse 9926c00494 ctrl_panel: Indicate active parameter of control 
Instead of hiding the inactive control parameter, underline and bold the
active control parameter title, e.g. "Set Current" when control method
is constant current, and "Setpoint" when it is temperature PID.
 2024-10-07 16:13:54 +08:00
atse fde1e6b3e4 ctrl_panel: Limits fixes 
* PID Autotune test current should be positive

* max_v should be 4 V not 5 V

* r0 should not be negative
 2024-10-07 16:03:00 +08:00
atse 873f16a675 ctrl_panel: Code cleanup 
* Remove unnecessary duplication of `THERMOSTAT_PARAMETERS`

* i -> ch

* Separate ParameterTree and Parameter initiation

* Remove extra "channel" option to root parameters, as the "value"
option is already the channel number
 2024-10-07 16:03:00 +08:00
atse 85c8c23f2c ctrl_panel: PID Auto Tune -> PID Autotune 2024-10-07 16:02:58 +08:00
atse ac10859f70 ctrl_panel: Stop crushing spinboxes 
It might not be the case on some themes, but on the default Qt theme the
spinbox are a bit too short for the containing numbers. See
https://github.com/pyqtgraph/pyqtgraph/issues/701.
 2024-10-07 16:02:04 +08:00
atse 4bda62ab41 ctrl_panel: Pin down units for editable fields 
User input always has the same order of magnitude, so allowing multiple
siPrefixes would be unwanted complexity. Don't allow them to be changed.

The Parameter option "noUnitEditing" is added to do so by the following
measures:

1. Don't validate for changed siPrefix (if pinned) and suffix, which
avoids their removal.

2. Avoid getting the cursor embedded within the unit.
 2024-10-07 16:01:50 +08:00
atse 6df37e31aa ctrl_panel: Remove need for "mA" hack 
Remove all instances of mA scaling scattered all around the code and
specify it in the parameter tree with a single source of truth.

Done by adding the option "pinSiPrefix" for all Parameters of type `int`
or `float`, and using it for current Parameters with unit "mA".
 2024-10-07 16:01:41 +08:00
atse 2df4c03c2d ctrl_panel: Appropriate units for measured current 
Allow the readonly display of current to vary its SI prefix in the unit,
since as a display entry it won't have the unit adjustment problem.
 2024-10-07 16:01:31 +08:00
atse 2b9bc020ce ctrl_panel: Improve postfilter description 2024-10-07 16:01:31 +08:00
atse dafde57e23 ctrl_panel: Add and improve tooltips and titles 
For users' better understanding of what the parameters do
 2024-10-07 16:01:29 +08:00
atse 6a38f9b5a6 ctrl_panel: Refer to Parameters by concise `name`s 
For displayed string representations, use the `title` key, or for
`ListParameter`s, use the dictionary mapping method instead.
 2024-10-07 16:01:21 +08:00
atse 9af4ffd125 ctrl_panel: Config -> Settings 2024-10-07 16:01:13 +08:00
atse 55a7583867 Format JSON 2024-10-07 16:01:11 +08:00
linuswck 19c3c7a8f2 Merge pull request 'GUI: Refactor `send_command`' (#4) from gui_dev-refactor-send_command into gui_dev 
Reviewed-on: linuswck/thermostat#4
 2024-10-07 13:03:38 +08:00
atse 41abad7aa3 send_command: Remove "activater" 
Interpret commands anomalies directly in send_command instead
 2024-08-14 16:07:15 +08:00
atse 5c8d9c7cce send_command: Simplify "pid_autotune" parameters 2024-08-14 16:07:15 +08:00