M-Labs
/
web2019
5
0
Fork 2
Code Issues 20 Pull Requests 3 Releases Wiki Activity

Add EEM power module to the shop #97

Merged
sb10q merged 2 commits from esavkin/web2019:91-eem-pwr_mod into master 2023-10-10 17:34:53 +08:00
Conversation 3 Commits 2 Files Changed 4 +52 -11
esavkin commented 2023-10-05 15:34:48 +08:00
Member
Copy Link

Closes #91
Waits for #93

Closes #91 Waits for #93
eem_pwr_mod_ac.svg
38 KiB
eem_pwr_mod_ac.svg
sb10q commented 2023-10-05 16:51:20 +08:00
Owner
Copy Link

Please make this independent of the options PR.

Please make this independent of the options PR.
👍 1
sb10q commented 2023-10-05 16:51:44 +08:00
Owner
Copy Link

There shouldn't be 35 commits just to add a card.

There shouldn't be 35 commits just to add a card.
😕 1 👀 1
esavkin force-pushed 91-eem-pwr_mod from 5f5463f84c to 9cf6322672 2023-10-05 16:59:25 +08:00 Compare
sb10q commented 2023-10-05 17:00:30 +08:00
Owner
Copy Link

Remove the handle graphic. Other cards don't have it either.
image

Remove the handle graphic. Other cards don't have it either. ![image](/attachments/b39192d5-e9ab-4ea9-9f0d-e81d66e47839)
image.png
5.4 KiB
sb10q reviewed 2023-10-05 17:02:16 +08:00
static/js/shop_data.js Outdated
@ -892,0 +904,4 @@
"EMC filter",
"LED current indicator",
"6 rear side outputs - 4pin Molex MiniFit (Kasli type)",
"Mains circuit protected with steel cover"
sb10q commented 2023-10-05 17:02:16 +08:00
Owner
Copy Link

Add an item saying it is optional and the crate comes with DC brick(s) if it doesn't have the EEM Power Module.

Add an item saying it is optional and the crate comes with DC brick(s) if it doesn't have the EEM Power Module.
sb10q reviewed 2023-10-05 17:02:38 +08:00
static/js/shop_data.js Outdated
@ -892,0 +899,4 @@
specs: [
"EEM AC power module",
"400W with forced cooling (25CFM), 200W with free air convection",
"80-264V input range",
sb10q commented 2023-10-05 17:02:38 +08:00
Owner
Copy Link

It's commonly called "universal input"

It's commonly called "universal input"
esavkin added 1 commit 2023-10-05 17:12:05 +08:00
7941904f45 Remove handle and update description 
Signed-off-by: Egor Savkin <es@m-labs.hk>
sb10q merged commit 393fc8e3c9 into master 2023-10-10 17:34:53 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/web2019#97
No description provided.
Delete Branch "esavkin/web2019:91-eem-pwr_mod"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?