M-Labs
/
thermostat
9
0
Fork 5
Code Issues 8 Pull Requests 9 Releases Wiki Activity

TCP command: Rename pwm to output #140

Open
atse wants to merge 1 commits from atse/thermostat:rename-pwm-output into master
pull from: atse/thermostat:rename-pwm-output
merge into: M-Labs:master
Conversation 0 Commits 1 Files Changed 7 +99 -99
atse commented 2024-10-14 16:00:58 +08:00
Contributor
Copy Link

Current limit pins are driven by PWM inputs to the MAX1968 driver, but this is an implementation detail, and should not be exposed in the form of the command interface. Rename "pwm" to "output" in all instances.

See #62 (comment).

Current limit pins are driven by PWM inputs to the MAX1968 driver, but this is an implementation detail, and should not be exposed in the form of the command interface. Rename "pwm" to "output" in all instances. See https://git.m-labs.hk/M-Labs/thermostat/issues/62#issue-725.
👍 1
atse added 1 commit 2024-10-14 16:00:58 +08:00
d7496e3362 TCP command: Rename `pwm` to `output` 
Current limit pins are driven by PWM inputs to the MAX1968 driver, but
this is an implementation detail, and should not be exposed in the form
of the command interface. Rename "pwm" to "output" in all instances.

See #62 (comment).
This pull request has changes conflicting with the target branch.
  • README.md
  • src/command_handler.rs
  • src/command_parser.rs
You can also view command line instructions.

Step 1:

From your project repository, check out a new branch and test the changes.
git checkout -b atse-rename-pwm-output master
git pull rename-pwm-output

Step 2:

Merge the changes and update on Gitea.
git checkout master
git merge --no-ff atse-rename-pwm-output
git push origin master
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
1 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#140
No description provided.
Delete Branch "atse/thermostat:rename-pwm-output"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?