M-Labs/thermostat
9
0
Fork 5
Code Issues 9 Pull Requests 5 Releases Wiki Activity

README: Add updated info on new hardware revision #130

Merged
sb10q merged 1 commits from atse/thermostat:readme-hwrev-update into master 2024-10-16 11:15:10 +08:00
Conversation 0 Commits 1 Files Changed 1 +1 -1
atse commented 2024-08-16 13:47:17 +08:00
Contributor
Copy Link

The noisy current readouts were fixed in hardware in 2822a83fb6, so reflect the change here in the README.

The noisy current readouts were fixed in hardware in https://github.com/sinara-hw/Thermostat/commit/2822a83fb6d84a3b83c1bdad04c1c2df238beaf2, so reflect the change here in the README.
👍 1
atse added 1 commit 2024-08-16 13:47:17 +08:00
esavkin reviewed 2024-10-14 10:22:24 +08:00
README.md Outdated
@ -272,3 +272,3 @@
| `pid_output` | Amperes | PID control output |
Note: With Thermostat v2 and below, the voltage and current readouts `i_tec` and `tec_i` are noisy without the hardware fix shown in [this PR][https://git.m-labs.hk/M-Labs/thermostat/pulls/105].
Note: Before Thermostat v2.2.4, the voltage and current readouts `i_tec` and `tec_i` are noisy without the hardware fix shown in [this PR](https://git.m-labs.hk/M-Labs/thermostat/pulls/105).
esavkin commented 2024-10-14 10:22:24 +08:00
Owner
Copy Link

I guess prior would be better word instead of before

I guess `prior` would be better word instead of `before`
atse commented 2024-10-14 10:41:45 +08:00
Author
Contributor
Copy Link

Ahh, so let's say this would go something like "Prior to Thermostat v2.2.4..." right?

Ahh, so let's say this would go something like "Prior to Thermostat v2.2.4..." right?
esavkin commented 2024-10-14 10:45:49 +08:00
Owner
Copy Link

If this note applies to the thermostats excluding 2.2.4, then yes

If this note applies to the thermostats excluding 2.2.4, then yes
👍 1
atse commented 2024-10-14 12:47:44 +08:00
Author
Contributor
Copy Link

Changed in latest force-push.

Changed in latest force-push.
atse marked this conversation as resolved
atse force-pushed readme-hwrev-update from 8fb389855c to 0064ae1056 2024-10-14 12:46:56 +08:00 Compare
sb10q merged commit d1df6b8e3a into master 2024-10-16 11:15:10 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#130
No description provided.
Delete Branch "atse/thermostat:readme-hwrev-update"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?