M-Labs
/
thermostat
9
0
Fork 5
Code Issues 10 Pull Requests 6 Releases Wiki Activity

Move PwmLimits into its own file #123

Closed
atse wants to merge 1 commits from atse:refactor-pwm_limits into master
pull from: atse:refactor-pwm_limits
merge into: M-Labs:master
Conversation 4 Commits 1 Files Changed 4 +30 -28
atse commented 2024-08-08 18:16:48 +08:00
Contributor
Copy Link
No description provided.
atse added 1 commit 2024-08-08 18:16:49 +08:00
atse force-pushed refactor-pwm_limits from 92d90de778 to c92fea8642 2024-10-14 15:19:38 +08:00 Compare
atse force-pushed refactor-pwm_limits from c92fea8642 to 16e91e8103 2024-10-14 15:23:43 +08:00 Compare
atse force-pushed refactor-pwm_limits from 16e91e8103 to 3ec5e185ee 2024-10-21 10:20:08 +08:00 Compare
atse force-pushed refactor-pwm_limits from 3ec5e185ee to 5b29f12a50 2024-10-21 16:01:22 +08:00 Compare
atse force-pushed refactor-pwm_limits from 5b29f12a50 to a506876995 2024-10-21 16:05:37 +08:00 Compare
sb10q commented 2024-10-21 16:08:06 +08:00
Owner
Copy Link

What is the purpose of doing this? It's a bit weird to have one such short file.

What is the purpose of doing this? It's a bit weird to have one such short file.
atse commented 2024-10-21 16:18:58 +08:00
Author
Contributor
Copy Link

Just thought putting PwmLimits in config.rs was a tad inappropriate for what it does. Perhaps I should move it over to channel_state.rs instead?

Just thought putting `PwmLimits` in config.rs was a tad inappropriate for what it does. Perhaps I should move it over to channel_state.rs instead?
sb10q commented 2024-10-21 16:22:17 +08:00
Owner
Copy Link

I think config.rs is fine? It's just a part of ChannelConfig, no?

I think config.rs is fine? It's just a part of ChannelConfig, no?
atse commented 2024-10-21 16:34:41 +08:00
Author
Contributor
Copy Link

Well, it's also a part of ChannelState. But yes looking at it again now it does fit a pattern together with ChannelConfig, with the new and apply methods. Closing this PR.

Well, it's also a part of ChannelState. But yes looking at it again now it does fit a pattern together with ChannelConfig, with the `new` and `apply` methods. Closing this PR.
atse closed this pull request 2024-10-21 16:34:41 +08:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No Label
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/thermostat#123
No description provided.
Delete Branch "atse:refactor-pwm_limits"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?