README.md

@@ -70,8 +70,6 @@ The scope of this setting is per TCP session.
 | `pid <0/1> integral_max <value>` | Set integral upper bound                            |
 | `s-h`                            | Show Steinhart-Hart equation parameters             |
 | `s-h <0/1> <t/b/r0> <value>`     | Set Steinhart-Hart parameter for a channel          |
-| `postfilter`                     | Show postfilter settings                            |
-| `postfilter <0/1> off`           | Disable postfilter                                  |
 | `postfilter <0/1> rate <rate>`   | Set postfilter output data rate                     |
 | `load`                           | Restore configuration from EEPROM                   |
 | `save`                           | Save configuration to EEPROM                        |

src/ad7172/mod.rs

@@ -1,6 +1,5 @@
 use core::fmt;
 use num_traits::float::Float;
-use serde::{Serialize, Deserialize};
 use stm32f4xx_hal::{
     time::MegaHertz,
     spi,
@@ -145,7 +144,7 @@ impl fmt::Display for RefSource {
     }
 }
 
-#[derive(Clone, Copy, Debug, PartialEq, Serialize, Deserialize)]
+#[derive(Clone, Copy)]
 #[repr(u8)]
 pub enum PostFilter {
     /// 27 SPS, 47 dB rejection, 36.7 ms settling

src/channels.rs

@@ -52,7 +52,6 @@ impl Channels {
         for channel in 0..CHANNELS {
             channels.channel_state(channel).vref = channels.read_vref(channel);
             channels.calibrate_dac_value(channel);
-            channels.set_i(channel, ElectricCurrent::new::<ampere>(0.0));
         }
         channels
     }
@@ -253,7 +252,7 @@ impl Channels {
 
     /// Calibrate the I_SET DAC using the DAC_FB ADC pin.
     ///
-    /// These loops perform a breadth-first search for the DAC setting
+    /// These loops perform a width-first search for the DAC setting
     /// that will produce a `target_voltage`.
     pub fn calibrate_dac_value(&mut self, channel: usize) {
         let target_voltage = ElectricPotential::new::<volt>(2.5);

src/command_parser.rs

@@ -164,7 +164,7 @@ pub enum Command {
     },
     PostFilter {
         channel: usize,
-        rate: Option<f32>,
+        rate: f32,
     },
 }
 
@@ -392,23 +392,15 @@ fn postfilter(input: &[u8]) -> IResult<&[u8], Result<Command, Error>> {
             |input| {
                 let (input, channel) = channel(input)?;
                 let (input, _) = whitespace(input)?;
-                alt((
-                    value(Ok(Command::PostFilter {
+                let (input, _) = tag("rate")(input)?;
+                let (input, _) = whitespace(input)?;
+                let (input, rate) = float(input)?;
+                let result = rate
+                    .map(|rate| Command::PostFilter {
                         channel,
-                        rate: None,
-                    }), tag("off")),
-                    move |input| {
-                        let (input, _) = tag("rate")(input)?;
-                        let (input, _) = whitespace(input)?;
-                        let (input, rate) = float(input)?;
-                        let result = rate
-                            .map(|rate| Command::PostFilter {
-                                channel,
-                                rate: Some(rate as f32),
-                            });
-                        Ok((input, result))
-                    }
-                ))(input)
+                        rate: rate as f32,
+                    });
+                Ok((input, result))
             }
         ),
         value(Ok(Command::Show(ShowCommand::PostFilter)), end)
@@ -578,27 +570,12 @@ mod test {
         }));
     }
 
-    #[test]
-    fn parse_postfilter() {
-        let command = Command::parse(b"postfilter");
-        assert_eq!(command, Ok(Command::Show(ShowCommand::PostFilter)));
-    }
-
-    #[test]
-    fn parse_postfilter_off() {
-        let command = Command::parse(b"postfilter 1 off");
-        assert_eq!(command, Ok(Command::PostFilter {
-            channel: 1,
-            rate: None,
-        }));
-    }
-
     #[test]
     fn parse_postfilter_rate() {
         let command = Command::parse(b"postfilter 0 rate 21");
         assert_eq!(command, Ok(Command::PostFilter {
             channel: 0,
-            rate: Some(21.0),
+            rate: 21.0,
         }));
     }
 

src/config.rs

@@ -9,7 +9,6 @@ use uom::si::{
     thermodynamic_temperature::degree_celsius,
 };
 use crate::{
-    ad7172::PostFilter,
     channels::{CHANNELS, Channels},
     command_parser::CenterPoint,
     EEPROM_SIZE, EEPROM_PAGE_SIZE,
@@ -95,18 +94,11 @@ pub struct ChannelConfig {
     pid_target: f32,
     sh: SteinhartHartConfig,
     pwm: PwmLimits,
-    /// uses variant `PostFilter::Invalid` instead of `None` to save space
-    adc_postfilter: PostFilter,
 }
 
 impl ChannelConfig {
     pub fn new(channels: &mut Channels, channel: usize) -> Self {
         let pwm = PwmLimits::new(channels, channel);
-
-        let adc_postfilter = channels.adc.get_postfilter(channel as u8)
-            .unwrap()
-            .unwrap_or(PostFilter::Invalid);
-
         let state = channels.channel_state(channel);
         ChannelConfig {
             center: state.center.clone(),
@@ -114,7 +106,6 @@ impl ChannelConfig {
             pid_target: state.pid.target as f32,
             sh: (&state.sh).into(),
             pwm,
-            adc_postfilter,
         }
     }
 
@@ -124,14 +115,7 @@ impl ChannelConfig {
         state.pid.parameters = self.pid.clone();
         state.pid.target = self.pid_target.into();
         state.sh = (&self.sh).into();
-
         self.pwm.apply(channels, channel);
-
-        let adc_postfilter = match self.adc_postfilter {
-            PostFilter::Invalid => None,
-            adc_postfilter => Some(adc_postfilter),
-        };
-        let _ = channels.adc.set_postfilter(channel as u8, adc_postfilter);
     }
 }
 
@@ -204,7 +188,6 @@ mod test {
                 max_i_pos: 2.1,
                 max_i_neg: 2.25,
             },
-            adc_postfilter: PostFilter::F21SPS,
         };
         let config = Config {
             channels: [
@@ -230,7 +213,6 @@ mod test {
                 max_i_pos: 2.1,
                 max_i_neg: 2.25,
             },
-            adc_postfilter: PostFilter::F21SPS,
         };
         let config = Config {
             channels: [

src/main.rs

@@ -308,7 +308,7 @@ fn main() -> ! {
                                             }
                                             None => {
                                                 let _ = writeln!(
-                                                    socket, "channel {}: postfilter disabled",
+                                                    socket, "channel {}: no postfilter",
                                                     channel
                                                 );
                                             }
@@ -421,14 +421,7 @@ fn main() -> ! {
                                     }
                                     let _ = writeln!(socket, "Steinhart-Hart equation parameter updated");
                                 }
-                                Command::PostFilter { channel, rate: None } => {
-                                    channels.adc.set_postfilter(channel as u8, None).unwrap();
-                                    let _ = writeln!(
-                                        socket, "channel {}: postfilter disabled",
-                                        channel
-                                    );
-                                }
-                                Command::PostFilter { channel, rate: Some(rate) } => {
+                                Command::PostFilter { channel, rate } => {
                                     let filter = ad7172::PostFilter::closest(rate);
                                     match filter {
                                         Some(filter) => {
@@ -466,10 +459,6 @@ fn main() -> ! {
                                     }
                                 }
                                 Command::Reset => {
-                                    for i in 0..CHANNELS {
-                                        channels.power_down(i);
-                                    }
-
                                     SCB::sys_reset();
                                 }
                             }