Commit Graph

2254 Commits

Author SHA1 Message Date
Sébastien Crozet ac61e112dd
Merge pull request #932 from CAD97/moar-const
Remove scalar bound from geometry type defs
2021-07-10 11:28:23 +02:00
Crozet Sébastien 2ce6811e2c Fix compilation when enabling the bytemuck feature. 2021-07-10 11:24:23 +02:00
CAD97 85d07b22a3 FIx serde impl bounds 2021-07-09 15:30:06 -05:00
CAD97 22ba88353a Fix bounds for bytemuck impls 2021-07-09 15:23:08 -05:00
Sébastien Crozet c5249f4c16
Merge pull request #940 from OfficialURL/safety
Removed unnecessary `unsafe` markers
2021-07-09 09:51:10 +02:00
Violeta Hernández 1be8964c12 Fixed indent 2021-07-08 11:15:08 -05:00
Violeta Hernández 04e937792b Removed unnecessary `unsafe` markers 2021-07-08 11:12:43 -05:00
Joshua Smith a7fe7a5d9a fixed check-fmt error 2021-07-08 11:05:32 -05:00
nathan.eckert dd1530adc3 Cargo fmt 2021-07-08 14:20:35 +02:00
nathan.eckert 92a51662bf Remove Allocator<usize, > from display 2021-07-08 14:18:22 +02:00
nathan.eckert 639382ea49 Add failing test higlighting the issue 2021-07-08 11:23:41 +02:00
Sébastien Crozet 40bc1cb304
Merge pull request #923 from OfficialURL/self_copy2
`&self` → `self` on `Copy` types.
2021-07-08 10:01:00 +02:00
Sébastien Crozet 0a5bd520a4
Merge pull request #922 from Cryptjar/impl-into-slice
Allow to extract the inner slices of SliceStorage
2021-07-08 09:50:41 +02:00
Sébastien Crozet a66b54a015
Merge pull request #929 from remilauzier/dev
Fix some clippy warnings and typo
2021-07-08 09:44:43 +02:00
Sébastien Crozet e58813915a
Merge pull request #934 from Andlon/point_dim_name
point_dim_name: Fix serde impls and Distribution impl for OPoint
2021-07-08 09:40:31 +02:00
Sébastien Crozet 40e6783a3a
Merge pull request #936 from OfficialURL/doc-comments
Trivial doc comment improvements
2021-07-08 09:39:35 +02:00
Joshua Smith 2279da446e impl Borrow and BorrowMut for fixed size matrices 2021-07-07 13:26:19 -05:00
Violeta Hernández 6e96c28ad9 Trivial doc comment improvements 2021-07-06 21:05:25 -05:00
Rémi Lauzier bbd60fbc8c
Fix some clippy warnings and typo 2021-07-06 11:39:29 -04:00
Sébastien Crozet 1fc29dcf63
Merge pull request #930 from CAD97/patch-1
impl Hash for Transform
2021-07-06 01:09:00 -07:00
Sébastien Crozet e417ec86d7
Merge pull request #931 from CAD97/patch-2
Rotation::matrix_mut_unchecked may not cause UB
2021-07-06 01:08:34 -07:00
CAD97 314b4dd103 Remove scalar bound from geometry type defs
This was inconsistently applied, with some types having <T>, some having
<T: Scalar>, and some having <T: RealField>.
This unifies all types to match the convention of Matrix:
Just declare <T> at type def time, and apply bounds on impls only.

A significant advantage of this approach is const fn construction. Const
fn generics currently still can't have trait bounds, so any generic
const fn needs to only move opaque types around. Construction methods
such as new_unchecked or from_parts can be made const by removing their
generic bounds after this PR.

Actual constification is left to a follow-up PR.

Note that na::Transform is _not_ loosened here, as it has more complicated
definition requirements.
2021-07-05 19:04:10 -05:00
Christopher Durham 1eeaf3526c
Rotation::matrix_mut_unchecked may not cause UB
...because it isn't unsafe, so clarify the documentation to match.
2021-07-05 18:53:11 -05:00
Christopher Durham 3b4b661756
impl Hash for Transform
This just fixes the types in the existing TODO to compile.
2021-07-05 18:36:33 -05:00
Sébastien Crozet b10711e66e
Merge pull request #927 from remilauzier/dev
Fix some clippy warnings
2021-07-05 06:55:26 -07:00
Sébastien Crozet 5b2b174b8b
Merge pull request #928 from CAD97/moar-const
Add a couple trivial const fn conversions
2021-07-05 06:55:17 -07:00
CAD97 e77a97e854 Add a couple trivial const fn conversions 2021-07-04 17:42:39 -05:00
Rémi Lauzier 78da5209e9
Fix some clippy warnings 2021-07-03 23:43:45 -04:00
Andreas Longva 92c26334ec Fix serde impls and Distribution impl for OPoint 2021-07-02 12:01:01 +02:00
CAD97 396d3d6615 Add missing repr(C) on bytemuckable geometry types 2021-06-28 20:49:57 -05:00
CAD97 cb0812aaf3 Add bytemuck impls to geometry types 2021-06-28 20:36:28 -05:00
Crozet Sébastien 16b8f4812d Define OPoint, a generic point with D: DimName
And define Point<T, const D: usize> as an alias for OPoint.
2021-06-26 18:39:20 +02:00
Violeta Hernández d659747fa4 `&self` → `self` on `Copy` types. 2021-06-18 12:53:38 -05:00
Cryptjar 1554c0114e Fix unsoundness in `into_slice` by adding `ContiguousStorage` bound. 2021-06-18 13:18:33 +02:00
Sébastien Crozet 0312981a4f
Merge pull request #921 from OfficialURL/ptr_alias
Fixed potential UB
2021-06-18 09:49:41 +02:00
Violeta Hernández 281b140365
Fix most clippy warnings 2021-06-18 09:45:37 +02:00
Violeta Hernández c5f240cc28 Fixed potential UB 2021-06-17 19:51:00 -05:00
Cryptjar 801d8a61a6 Add a `From` impl to convert `DVectorSlice[mut]` back to into a slice. 2021-06-18 02:50:10 +02:00
Cryptjar 498b377d0e Add `into_slice[_mut]` and impl to SliceStorage[Mut]. 2021-06-18 02:42:03 +02:00
Sébastien Crozet 38add0b00d
Fix potential undoundness with Storage::as_slice and Storage::as_mut_slice (#905) 2021-06-17 09:46:49 +02:00
Violeta Hernández d64e799fc9
Fixes #909 (#917) 2021-06-17 09:45:33 +02:00
Violeta Hernández 7643a24cc1
`Result<(), ()>` to `bool` (#916) 2021-06-17 09:44:06 +02:00
Violeta Hernández 885bbdaf97
Implemented `SliceRange` for `RangeInclusive` (#911) 2021-06-17 09:42:47 +02:00
Sébastien Crozet 2287e5088a
Merge pull request #904 from CattleProdigy/coo-push-mat
Add push_matrix fcn to COO
2021-06-14 14:39:16 +02:00
Paul Jakob Schroeder e6e7efba8a COO: add push_matrix fn
- This function allows one to add entire dense matrices
to a sparse COO matrix.
- Added a small mention of this new function in the
example in lib.rs
2021-06-08 10:05:50 -04:00
Sébastien Crozet 543f964610
Merge pull request #851 from MalteT/dev
Annotate functions with #[must_use] where appropriate
2021-06-08 11:01:33 +02:00
Malte Tammena 9eb9ad603f Add `get_mut` annotations (second try) 2021-06-07 17:24:43 +02:00
Malte Tammena 38e9a5da33 Annotate `get_mut`/`slice`-like functions with `#[must_use]` 2021-06-07 17:15:36 +02:00
Malte Tammena e1fe76235f Normalize `#[must_use]` hints 2021-06-07 16:44:59 +02:00
Malte Tammena 9fb963017f Simplify default `#[must_use]` annotation 2021-06-07 16:34:03 +02:00