Commit Graph

2288 Commits

Author SHA1 Message Date
YuhanLiin 1acd48f6f1 Address review comments 2022-03-09 21:04:43 -05:00
YuhanLiin 325618ba22 Fix SVD instability bug 2022-03-09 02:13:12 -05:00
Anton Arsenij 757b99e843
CSC: Create constructor for unsorted but otherwise valid data (#1015)
* CSC: Create constructor for unsorted but otherwise valid data

* Test creating csc matrix from unsorted but valid data

* Add function for validation and sorting

* Move validation function to cs.rs

* Restore pattern unit test

* Add unit test for 'major offset out of bounds' case

* Avoid permutation allocations on 'happy path'

* Reuse allocated permutation

* Fix comments for test-data examples

* Remove unnecessary iter variable

* Set up buffers for sorting up front

* Use common apply_permutation function

* Use common compute_sort_permutation function

* Move unsafe down to unchecked call

* Add panic cases to documentation

* Remove unnecessary Zero bound

* Move buffer set up away from loop

* Lift T::Zero from cs.rs

* Improve checking if values are provided

* Simplify copying from slices & add test for wrong values length

* Check duplicates after sorting

* Fix formatting

* Check values length at the beginning

* Check length of values if values != None
2022-03-03 10:14:16 +01:00
Sébastien Crozet f637013aa0
Merge pull request #1077 from wucke13/dev
fix #1073: typo in name of macros feature
2022-02-14 14:20:00 +01:00
Wanja Zaeske 104cb944b9 fix #1073: typo in name of macros feature 2022-02-14 13:55:16 +01:00
Sébastien Crozet 39bb572557
Merge pull request #1074 from saethlin/remove-abomonation
Remove abomonation support
2022-02-07 09:31:40 +01:00
Ben Kimock 18730dd986 2022-02-06 10:03:22 -05:00
Ben Kimock 698e130c3b Remove abomonation support
Abomonation has numerous soundness problems which have been
well-documented in its issue tracker for over 2 years. Some of them
could be fixed, but some are fundamental to its design. If a user wants
super-fast ser/de, they should use rkyv.
2022-02-05 17:15:08 -05:00
Sébastien Crozet 7ade44dc1d
Merge pull request #1019 from w1th0utnam3/sparse_serde
Implement Serde Serialize/Deserialize for nalgebra-sparse types
2022-01-24 11:40:51 -08:00
Fabian Loeschner 99eb8c1589 Revert "Rename nrows/ncols args for try_from_*_data functions for consistency"
This reverts commit 2a3e657b56.
2022-01-13 10:28:00 +01:00
Fabian Loeschner 89f1e855bb Revert "Fix panic in SparsityPattern::try_from_* if major index is out of bounds"
This reverts commit 12afe2917af4c30fc4a17316e453d0830072642c to avoid conflict with #1015.
2022-01-11 10:35:07 +01:00
Fabian Loeschner 38989ed5f0 Move sparse matrix serialization to separate files 2022-01-11 10:35:07 +01:00
Fabian Löschner 583fde05fe Add comment explaining intermediate types for serialization 2022-01-11 10:35:07 +01:00
Fabian Löschner fe70a80e41 Partial revert "Use custom serde errors, make all sparse errs lowercase" 2022-01-11 10:35:07 +01:00
Fabian Loeschner 513178e03e Revert "Updated more error messages"
This reverts commit a42eae45e045c391ede37a7a4328c09cbbb87a0f.
2022-01-11 10:35:07 +01:00
Fabian Löschner 647455dadd Move serialization code to submodules 2022-01-11 10:35:07 +01:00
Fabian Löschner 837ded932e Replace usage of Cow with generic type 2022-01-11 10:35:07 +01:00
Fabian Löschner 49eb1bd778 CI: Run nalgebra-sparse builds with different feature sets, serde tests 2022-01-11 10:35:07 +01:00
Fabian Löschner 9b87fa4ffa Add cfg attribute to Cow imports 2022-01-11 10:35:07 +01:00
Fabian Löschner a8fa7f71c0 Unify separate (de)serialization helper structs by using Cow<'a, [T]> 2022-01-11 10:35:07 +01:00
Fabian Loeschner 3be81be2e3 Updated more error messages 2022-01-11 10:35:07 +01:00
Fabian Loeschner 7e67d920a7 Use custom serde errors, make all sparse errs lowercase w/o punctuation 2022-01-11 10:35:07 +01:00
Fabian Loeschner e9b7718292 Fix panic in SparsityPattern::try_from_* if major index is out of bounds 2022-01-11 10:35:07 +01:00
Fabian Loeschner e2c33b48ac Simplify Deserialize bound 2022-01-11 10:35:07 +01:00
Fabian Loeschner bfaf29393c Implement Serialize, Deserialize for SparsityPattern 2022-01-11 10:35:07 +01:00
Fabian Loeschner 2a3e657b56 Rename nrows/ncols args for try_from_*_data functions for consistency 2022-01-11 10:35:07 +01:00
Fabian Loeschner 40d8a904a3 Implement Serialize, Deserialize for Csc, Coo; move helper out of impls 2022-01-11 10:35:07 +01:00
Fabian Loeschner 18b694dad2 Move serialization helper structs into trait impls 2022-01-11 10:35:07 +01:00
Fabian Löschner f9aca24b15 Implement Serialize and Deserialize for CsrMatrix 2022-01-11 10:35:07 +01:00
Sébastien Crozet 6cc633474d Update changelog. 2022-01-09 14:40:39 +01:00
Sébastien Crozet 6b1e14c8a2 Release v0.30.1 2022-01-09 14:37:25 +01:00
Sébastien Crozet 2026cb3bd3
Merge pull request #1062 from dimforge/glam-020
Add support for conversion with glam 0.19 and 0.20
2022-01-09 14:35:19 +01:00
Sébastien Crozet 87a6f4965b Add support for conversion with glam 0.19 and 0.20 2022-01-09 13:43:45 +01:00
Sébastien Crozet e8b9c40123 Release v0.30.0 2022-01-02 15:30:15 +01:00
Sébastien Crozet c0f8530d5e
Merge pull request #1055 from dimforge/fix-pow
Fix Matrix::pow and make it work with integer matrices
2021-12-31 09:57:56 +01:00
Sébastien Crozet 99ac8c4032
Merge pull request #1050 from metric-space/polar-decomposition-take-2
Take-2 of polar-decomposition
2021-12-31 09:57:08 +01:00
metric-space 498d7e3d4c Semi-unitary test checks for if rows or cols are orthonomal 2021-12-30 21:18:58 -05:00
metric-space ae6fda7dc7 Change svd to svd_unordered for the method output to be equal
Comment out unitary check for now
2021-12-30 21:12:37 -05:00
Sébastien Crozet d806669cc7 Fix Matrix::pow and make it work only with positive exponents 2021-12-30 23:03:43 +01:00
Sébastien Crozet fdaf8c0fbe Add tests for Matrix::pow 2021-12-30 23:03:22 +01:00
Sébastien Crozet 67a82c2c88 Test: minor style fix 2021-12-30 22:28:55 +01:00
Sébastien Crozet 8e0ca439c2 Use proptest for testing the polar decomposition 2021-12-30 22:15:22 +01:00
Sébastien Crozet cc10b67dd1 Add Matrix::try_polar that returns Option and make Matrix::polar not return Option 2021-12-30 22:15:04 +01:00
Sébastien Crozet b62b65d1b6
Merge pull request #1048 from haibane-tenshi/relax-matrix-select-rows-cols
Relax T: Zero bound on Matrix::select_rows() and Matrix::select_columns()
2021-12-30 21:56:55 +01:00
Sébastien Crozet a6007de409 Add "Triangular matrix extraction" bullet to Matrix documentation 2021-12-30 21:55:29 +01:00
Sébastien Crozet 2844c55de2
Merge pull request #1053 from rokonio/patch-1
Fix a typo in a comment
2021-12-30 21:46:47 +01:00
Sébastien Crozet 81f3c6e118
Merge pull request #1052 from sed-i/patch-1
minor doc fix (QR -> LU)
2021-12-30 21:46:28 +01:00
Rokonio 05320147b1
Fix a typo in a comment 2021-12-29 18:46:01 +01:00
metric-space 43c1f8fb9d Increased strength of tests for polar decomposition 2021-12-27 02:12:54 -05:00
metric-space dbaefed8d1 Fix doc typos 2021-12-26 21:05:42 -05:00