M-Labs
/
nalgebra
3
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

use PartialOrd with SimdRealField implementation of `rem` function 

instead of num::Euclid
This commit is contained in:
Jonas Pleyer 2024-06-13 16:31:52 +02:00
parent a1f34d5926
commit 1dcb9d649b
1 changed files with 9 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/base/matrix.rs
View File

@ -2111,7 +2111,7 @@ impl<T: Scalar + ClosedAdd + ClosedSub + ClosedMul, R: Dim, C: Dim, S: RawStorag
} }
} }
impl<T: crate::SimdRealField + num::Euclid + ClosedMul, R: Dim, C: Dim, S: RawStorage<T, R, C>> impl<T: crate::SimdRealField + PartialOrd + ClosedMul, R: Dim, C: Dim, S: RawStorage<T, R, C>>
Matrix<T, R, C, S> Matrix<T, R, C, S>
{ {
/// Calculate the right-handed angle between two vectors in radians. /// Calculate the right-handed angle between two vectors in radians.
@ -2154,11 +2154,16 @@ impl<T: crate::SimdRealField + num::Euclid + ClosedMul, R: Dim, C: Dim, S: RawSt
shape shape
); );
let two_pi =
(T::SimdRealField::one() + T::SimdRealField::one()) * T::SimdRealField::simd_pi();
let perp = -self.perp(other); let perp = -self.perp(other);
let dot = self.dot(other); let dot = self.dot(other);
T::SimdRealField::simd_atan2(perp, dot).rem_euclid( let res: T::SimdRealField = T::SimdRealField::simd_atan2(perp, dot) % two_pi.clone();
&((T::SimdRealField::one() + T::SimdRealField::one()) * T::SimdRealField::simd_pi()), if res < T::SimdRealField::zero() {
) res + two_pi
} else {
res
}
} }
} }