From 1dcb9d649b90d2cad25f13861b1d02fd539384f1 Mon Sep 17 00:00:00 2001
From: Jonas Pleyer <jonas.pleyer@fdm.uni-freiburg.de>
Date: Thu, 13 Jun 2024 16:31:52 +0200
Subject: [PATCH] use PartialOrd with SimdRealField implementation of `rem`
 function instead of num::Euclid

---
 src/base/matrix.rs | 13 +++++++++----
 1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/src/base/matrix.rs b/src/base/matrix.rs
index f690071f..efba5887 100644
--- a/src/base/matrix.rs
+++ b/src/base/matrix.rs
@@ -2111,7 +2111,7 @@ impl<T: Scalar + ClosedAdd + ClosedSub + ClosedMul, R: Dim, C: Dim, S: RawStorag
     }
 }
 
-impl<T: crate::SimdRealField + num::Euclid + ClosedMul, R: Dim, C: Dim, S: RawStorage<T, R, C>>
+impl<T: crate::SimdRealField + PartialOrd + ClosedMul, R: Dim, C: Dim, S: RawStorage<T, R, C>>
     Matrix<T, R, C, S>
 {
     /// Calculate the right-handed angle between two vectors in radians.
@@ -2154,11 +2154,16 @@ impl<T: crate::SimdRealField + num::Euclid + ClosedMul, R: Dim, C: Dim, S: RawSt
             shape
         );
 
+        let two_pi =
+            (T::SimdRealField::one() + T::SimdRealField::one()) * T::SimdRealField::simd_pi();
         let perp = -self.perp(other);
         let dot = self.dot(other);
-        T::SimdRealField::simd_atan2(perp, dot).rem_euclid(
-            &((T::SimdRealField::one() + T::SimdRealField::one()) * T::SimdRealField::simd_pi()),
-        )
+        let res: T::SimdRealField = T::SimdRealField::simd_atan2(perp, dot) % two_pi.clone();
+        if res < T::SimdRealField::zero() {
+            res + two_pi
+        } else {
+            res
+        }
     }
 }