M-Labs/nac3
M-Labs/nac3
8
1
Fork 13
Code Issues 100 Pull Requests 5 Releases Wiki Activity

nac3artiq: support kernels sent by content #555

Merged
sb10q merged 1 commits from mwojcik/nac3:submit_by_content into master 2024-11-22 19:38:52 +08:00
Conversation 0 Commits 1 Files Changed 2 +45 -14
mwojcik commented 2024-11-21 11:15:33 +08:00
Member
Copy Link

Closes #226.

ARTIQ part.

I noticed that nac3profile derivation in the flake is using hardcoded ARTIQ revision. This circular dependency actually broke my code - I needed to pass extra modules somehow, but the old hardcoded version of course did not provide it. For development, I removed nac3profile from the flake. It has to be updated after ARTIQ changes get merged.

Closes #226. [ARTIQ part](https://github.com/m-labs/artiq/pull/2622). I noticed that ``nac3profile`` derivation in the flake is using hardcoded ARTIQ revision. This circular dependency actually broke my code - I needed to pass extra modules somehow, but the old hardcoded version of course did not provide it. For development, I removed nac3profile from the flake. It has to be updated after ARTIQ changes get merged.
mwojcik added 1 commit 2024-11-21 11:15:33 +08:00
sb10q requested review from derppening 2024-11-21 18:02:58 +08:00
derppening approved these changes 2024-11-22 16:44:22 +08:00
sb10q merged commit e0dedc6580 into master 2024-11-22 19:38:52 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
derppening
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#555
No description provided.
Delete Branch "mwojcik/nac3:submit_by_content"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?