M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 99 Pull Requests 21 Releases Wiki Activity

Add support for global variables without type annotation #548

Merged
sb10q merged 4 commits from enhance/global-var into master 2024-10-08 09:05:38 +08:00
Conversation 0 Commits 4 Files Changed 6 +131 -108
derppening commented 2024-10-07 17:16:41 +08:00
Collaborator
Copy Link
No description provided.
derppening added 2 commits 2024-10-07 17:16:41 +08:00
derppening requested review from sb10q 2024-10-07 17:17:09 +08:00
sb10q reviewed 2024-10-07 17:43:34 +08:00
nac3core/src/toplevel/composer.rs Outdated
@ -384,1 +384,4 @@
ast::StmtKind::Assign { .. } => {
panic!("Registration of top-level Assign statements must use TopLevelComposer::register_top_level_var (at {})", ast.location);
}
sb10q commented 2024-10-07 17:43:34 +08:00
Owner
Copy Link

It's rather confusing why there is such a difference between Assign and AnnAssign. Maybe further code comments would help?

It's rather confusing why there is such a difference between Assign and AnnAssign. Maybe further code comments would help?
derppening commented 2024-10-07 20:44:56 +08:00
Author
Collaborator
Copy Link

Added a code comment explaining why the difference in behavior.

Added a code comment explaining why the difference in behavior.
👍 1
derppening force-pushed enhance/global-var from b2bfd0e9b3 to 5839badadd 2024-10-07 20:44:14 +08:00 Compare
sb10q merged commit 5839badadd into master 2024-10-08 09:05:38 +08:00
sb10q deleted branch enhance/global-var 2024-10-08 09:05:38 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
sb10q
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#548
No description provided.
Delete Branch "enhance/global-var"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?