Fix several issues with global variables #547

derppening · 2024-10-07T13:15:29+08:00

derppening commented

2024-10-07 13:15:29 +08:00

Added checking for global declaration after a corresponding local variable declaration, and use of global variables prior to a global declaration
Fixed materialization of global variables when accessed implicitly

- Added checking for `global` declaration after a corresponding local variable declaration, and use of global variables prior to a `global` declaration - Fixed materialization of global variables when accessed implicitly

derppening added 5 commits 2024-10-07 13:15:29 +08:00

1a197c67f6 [core] toplevel/composer: Reduce lock scope while analyzing function

51bf126a32 [core] typecheck/type_inferencer: Differentiate global symbols

Required for analyzing use of global symbols before global declaration.

3ce2eddcdc [core] typecheck/type_inferencer: Infer whether variables are global

42a2f243b5 [core] typecheck: Disallow redeclaration of var shadowing global

2bb788e4bb [core] codegen/expr: Materialize implicit globals

Required for when globals are read without the use of a global
declaration.

derppening requested review from sb10q 2024-10-07 13:18:42 +08:00

sb10q merged commit 2bb788e4bb into master

2024-10-07 13:58:44 +08:00

sb10q deleted branch enhance/global-var

2024-10-07 13:58:45 +08:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

1 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#547