meta: use clang -x c++ instead of clang++ #449

lyken · 2024-07-07T20:47:51+08:00

lyken commented

2024-07-07 20:47:51 +08:00

To deal with hydraJobs.nac3artiq-msys2 failing. See https://nixbld.m-labs.hk/build/161772.

The issue: llvm-nac3 in nix/windows/default.nix does not produce clang++.exe, and nac3core/build.rs is directly using clang++ to compile irrt.c, so building nac3core would fail with "clang++ command not error".

Pull request to change nac3core/build.rs from using clang++ to clang -x c++ (in fact adding -x c++ is redundant, clang could figure out that the source irrt.cpp is C++ and compiles accordingly, but I will specify it anyway). The flakes have also been updated.

To deal with `hydraJobs.nac3artiq-msys2` failing. See https://nixbld.m-labs.hk/build/161772. The issue: `llvm-nac3` in `nix/windows/default.nix` does not produce `clang++.exe`, and `nac3core/build.rs` is directly using `clang++` to compile `irrt.c`, so building `nac3core` would fail with "`clang++` command not error". Pull request to change `nac3core/build.rs` from using `clang++` to `clang -x c++` (in fact adding `-x c++` is redundant, `clang` could figure out that the source `irrt.cpp` is C++ and compiles accordingly, but I will specify it anyway). The flakes have also been updated.

lyken added 1 commit 2024-07-07 20:47:51 +08:00

76defac462 meta: use clang -x c++ instead of clang++

lyken requested review from sb10q 2024-07-07 20:47:57 +08:00

sb10q merged commit 76defac462 into master

2024-07-09 04:43:23 +08:00

sb10q deleted branch no-clang++

2024-07-09 04:43:23 +08:00

Sign in to join this conversation.

No reviewers