M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 99 Pull Requests 21 Releases Wiki Activity

nac3artiq: add support string attributes in classes #416

Merged
sb10q merged 1 commits from issue-337 into master 2024-06-17 16:53:51 +08:00
Conversation 3 Commits 1 Files Changed 3 +37
abdul124 commented 2024-06-14 15:27:58 +08:00
Collaborator
Copy Link

The main changes are as follows:
nac3artiq/src/lib.rs:

Added String to the list of primitive attributes

nac3artiq/src/symbol_resolver.rs

Recognize String Attributes #337

Added a demo file under nac3artiq/demo to test new changes

The main changes are as follows: nac3artiq/src/lib.rs: > Added String to the list of primitive attributes nac3artiq/src/symbol_resolver.rs > Recognize String Attributes #337 Added a demo file under nac3artiq/demo to test new changes
abdul124 requested review from derppening 2024-06-17 12:05:08 +08:00
derppening commented 2024-06-17 13:08:12 +08:00
Collaborator
Copy Link

Could you update the commit message? String is already a primitive type, and AFAIK you're just adding support for the str attribute.

And are there any changes to nac3standalone? Is str already supported there?

Could you update the commit message? String is already a primitive type, and AFAIK you're just adding support for the `str` attribute. And are there any changes to `nac3standalone`? Is `str` already supported there?
abdul124 commented 2024-06-17 13:39:56 +08:00
Author
Collaborator
Copy Link

Could you update the commit message? String is already a primitive type, and AFAIK you're just adding support for the str attribute.

I will change the commit message to "nac3artiq: support string attributes in classes"

And are there any changes to nac3standalone? Is str already supported there?

str attributes are supported there. The test case nac3standalone/demo/src/demo_test.py tests for string storing and printing capabilities.

> Could you update the commit message? String is already a primitive type, and AFAIK you're just adding support for the `str` attribute. I will change the commit message to "nac3artiq: support string attributes in classes" > And are there any changes to `nac3standalone`? Is `str` already supported there? `str` attributes are supported there. The test case nac3standalone/demo/src/demo_test.py tests for string storing and printing capabilities.
abdul124 force-pushed issue-337 from 0fa8cd21cd to 8cab8f08cb 2024-06-17 14:14:46 +08:00 Compare
abdul124 changed title from nac3artiq: Add String to Primitive Types to nac3artiq: add support string attributes in classes 2024-06-17 14:16:50 +08:00
derppening commented 2024-06-17 14:18:51 +08:00
Collaborator
Copy Link

Rest of the changes LGTM.

Rest of the changes LGTM.
derppening requested review from sb10q 2024-06-17 14:19:03 +08:00
derppening approved these changes 2024-06-17 14:19:06 +08:00
sb10q merged commit ce3e9bf4fe into master 2024-06-17 16:53:51 +08:00
sb10q deleted branch issue-337 2024-06-17 16:53:52 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
sb10q
derppening
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#416
No description provided.
Delete Branch "issue-337"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?