M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 5
Code Issues 91 Pull Requests 6 Releases Wiki Activity

Add cargo clippy and cargo fmt to pre-commit hooks #413

Merged
sb10q merged 5 commits from misc/workflow-updates into master 2024-06-12 16:12:19 +08:00
Conversation 5 Commits 5 Files Changed 36 +574 -427
derppening commented 2024-06-12 15:39:26 +08:00
Collaborator
Copy Link
  • Deny clippy::all warnings by default
  • Add more warnings, including Rust 2024 edition compatibility warnings
  • Add pre-commit hooks to check for style and format violations

I would prefer this to be merged once everyone is done with their currently-active feature to minimize conflicts.

- Deny `clippy::all` warnings by default - Add more warnings, including Rust 2024 edition compatibility warnings - Add `pre-commit` hooks to check for style and format violations I would prefer this to be merged once everyone is done with their currently-active feature to minimize conflicts.
derppening added 6 commits 2024-06-12 15:39:27 +08:00
52cc822a53 meta: Set clippy lints in {main,lib}.rs 
So that this does not have to be manually passed to the `cargo clippy`
command-line every single time. Also allows incrementally addressing
these lints by removing and fixing them one-by-one.
b55892e8cf meta: Reformat codebase using `cargo fmt` 
In preparation for pre-commit hooks.
derppening requested review from sb10q 2024-06-12 15:40:05 +08:00
sb10q commented 2024-06-12 15:41:08 +08:00
Owner
Copy Link

Let's just take care of #408 and then merge this.

Let's just take care of #408 and then merge this.
sb10q commented 2024-06-12 15:44:47 +08:00
Owner
Copy Link

Needs rewriting the fmt commit

Needs rewriting the fmt commit
derppening force-pushed misc/workflow-updates from 01ea93706d to 2c9b1f5330 2024-06-12 16:06:47 +08:00 Compare
derppening commented 2024-06-12 16:07:01 +08:00
Author
Collaborator
Copy Link

v2: Rebased onto master, added Rustrover configuration files

v2: Rebased onto master, added Rustrover configuration files
sb10q commented 2024-06-12 16:08:23 +08:00
Owner
Copy Link

added Rustrover configuration files

Please remove them, we generally don't include settings for any particular IDE in our projects.

> added Rustrover configuration files Please remove them, we generally don't include settings for any particular IDE in our projects.
derppening force-pushed misc/workflow-updates from 2c9b1f5330 to be55e2ac80 2024-06-12 16:11:42 +08:00 Compare
derppening commented 2024-06-12 16:11:55 +08:00
Author
Collaborator
Copy Link

v3: Removed Rustrover configurations

v3: Removed Rustrover configurations
sb10q merged commit be55e2ac80 into master 2024-06-12 16:12:19 +08:00
sb10q deleted branch misc/workflow-updates 2024-06-12 16:12:20 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
sb10q
Labels
Clear labels   
UROP0622

   
future-extension

   
high-priority

   
low-priority
No Label
UROP0622
future-extension
high-priority
low-priority
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#413
No description provided.
Delete Branch "misc/workflow-updates"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?