core: Add use_demo_lib option #402

Closed
derppening wants to merge 2 commits from misc/add-debug-func-invocation into master
Collaborator

Allows injecting calls to demo library functions for debugging.

Allows injecting calls to demo library functions for debugging.
derppening added 1 commit 2024-05-30 13:33:33 +08:00
4d0d4e0eae core: Add use_demo_lib option
Allows injecting calls to demo library functions for debugging.
derppening requested review from sb10q 2024-05-30 13:33:40 +08:00
derppening force-pushed misc/add-debug-func-invocation from 77113ed987 to 7e98ffd84f 2024-05-30 16:09:39 +08:00 Compare
derppening changed title from core: Add use_demo_lib option to WIP: core: Add use_demo_lib option 2024-05-30 16:11:08 +08:00
derppening force-pushed misc/add-debug-func-invocation from 7e98ffd84f to bf36da6deb 2024-05-30 16:15:10 +08:00 Compare
derppening changed title from WIP: core: Add use_demo_lib option to core: Add use_demo_lib option 2024-05-30 16:15:14 +08:00
derppening force-pushed misc/add-debug-func-invocation from bf36da6deb to 35c346881d 2024-05-30 16:16:31 +08:00 Compare
derppening added a new dependency 2024-05-30 16:16:52 +08:00
Owner

Looks like a massive kludge. Why do we need this? Isn't there a cleaner way to achieve the same result?

Looks like a massive kludge. Why do we need this? Isn't there a cleaner way to achieve the same result?
Owner

Can you just apply it as temporary patch in your local working tree as needed? I don't see why this should become part of the core codebase.

Can you just apply it as temporary patch in your local working tree as needed? I don't see why this should become part of the core codebase.
derppening removed a dependency 2024-06-03 17:33:13 +08:00
derppening closed this pull request 2024-06-03 17:33:44 +08:00

Pull request closed

Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#402
No description provided.