M-Labs
/
nac3
8
0
Fork 5
Code Issues 87 Pull Requests 3 Releases Wiki Activity

Use TObj to represent NDArrays and remove TNDArray #383

Merged
sb10q merged 2 commits from enhance/issue-149-ndarray into master 2024-03-01 15:54:51 +08:00
Conversation 0 Commits 2 Files Changed 21
derppening commented 2024-03-01 15:44:35 +08:00
Collaborator

ndarray is not a special type category.

`ndarray` is not a special type category.
derppening added 2 commits 2024-03-01 15:44:35 +08:00
c3db6297d9 core: Add primitive definition-id list 
So that we have a single ground truth for the definition IDs of
primitive types.
derppening requested review from sb10q 2024-03-01 15:44:43 +08:00
sb10q reviewed 2024-03-01 15:54:28 +08:00
nac3core/src/toplevel/helper.rs
@ -8,0 +52,4 @@
}
}
/// The [definition IDs][DefinitionId] for primitive types.
sb10q commented 2024-03-01 15:54:28 +08:00
Owner

That's definitely an improvement over the current code but I wonder if we should just use Enum and similar?

That's definitely an improvement over the current code but I wonder if we should just use Enum and similar?
derppening commented 2024-03-01 22:46:50 +08:00
Poster
Collaborator

Added a new issue for that (#385)

Added a new issue for that (#385)
sb10q merged commit 234a6bde2a into master 2024-03-01 15:54:51 +08:00
sb10q deleted branch enhance/issue-149-ndarray 2024-03-01 15:54:52 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
sb10q
Labels
Clear labels   
UROP0622
   
future-extension
   
high-priority
   
low-priority
No Label
UROP0622
future-extension
high-priority
low-priority
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#383
There is no content yet.
Delete Branch "enhance/issue-149-ndarray"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?