M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 99 Pull Requests 21 Releases Wiki Activity

Implement ndarray class, constructor and creation functions #371

Merged
sb10q merged 1 commits from enhance/issue-149-ndarray into master 2024-08-17 17:37:20 +08:00
Conversation 1 Commits 1 Files Changed 10 +1130 -105
derppening commented 2023-12-21 15:46:48 +08:00
Collaborator
Copy Link

Still missing:

  • ndarray member functions and subscript operator
Still missing: - ndarray member functions and subscript operator
👍 1
derppening self-assigned this 2023-12-21 15:46:48 +08:00
derppening added 7 commits 2023-12-21 15:46:48 +08:00
bd792904f9 core: Add size_t to primitive store 
Used for ndims in ndarray.
e435b25756 core: Allow implicit promotions of integral literals 
It should not matter, since it is the value of the literal that matters
with respect to the const generic variable.
03870f222d core: Extract special method handling in type inferencer 
To prepare for more special handling with methods.
derppening requested review from sb10q 2023-12-21 15:46:56 +08:00
sb10q reviewed 2023-12-21 15:52:03 +08:00
nac3core/src/toplevel/builtins.rs Outdated
@ -278,6 +286,32 @@ pub fn get_builtins(primitives: &mut (PrimitiveStore, Unifier)) -> BuiltinInfo {
let boolean = primitives.0.bool;
let range = primitives.0.range;
let string = primitives.0.str;
// TODO(Derppening): Could we make this generic?
sb10q commented 2023-12-21 15:52:03 +08:00
Owner
Copy Link

The issue tracker may be a more appropriate place for this.

The issue tracker may be a more appropriate place for this.
derppening commented 2023-12-22 16:35:39 +08:00
Author
Collaborator
Copy Link

Opened #372.

Opened #372.
sb10q reviewed 2023-12-21 15:55:08 +08:00
nac3core/src/toplevel/mod.rs Outdated
@ -25,6 +25,7 @@ pub struct DefinitionId(pub usize);
pub mod builtins;
pub mod composer;
pub mod helper;
mod numpy;
sb10q commented 2023-12-21 15:55:08 +08:00
Owner
Copy Link

Not pub?

Not pub?
derppening marked this conversation as resolved
derppening force-pushed enhance/issue-149-ndarray from 8abdaac562 to ef12ae062c 2023-12-22 16:05:35 +08:00 Compare
derppening force-pushed enhance/issue-149-ndarray from ef12ae062c to 140f8f8a08 2023-12-22 16:31:31 +08:00 Compare
derppening commented 2023-12-22 16:32:47 +08:00
Author
Collaborator
Copy Link

v2, v3: Addressed above comments, added support for running ndarray.py tests in Python

v2, v3: Addressed above comments, added support for running `ndarray.py` tests in Python
sb10q merged commit 140f8f8a08 into master 2023-12-22 17:11:28 +08:00
sb10q deleted branch enhance/issue-149-ndarray 2023-12-22 17:11:29 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
sb10q
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
derppening
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#371
No description provided.
Delete Branch "enhance/issue-149-ndarray"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?