Implement ndarray class, constructor and creation functions #371

Merged
sb10q merged 9 commits from enhance/issue-149-ndarray into master 2023-12-22 17:11:28 +08:00
Collaborator

Still missing:

  • ndarray member functions and subscript operator
Still missing: - ndarray member functions and subscript operator
derppening self-assigned this 2023-12-21 15:46:48 +08:00
derppening added 9 commits 2023-12-21 15:46:48 +08:00
derppening requested review from sb10q 2023-12-21 15:46:56 +08:00
sb10q reviewed 2023-12-21 15:52:03 +08:00
@ -278,6 +286,32 @@ pub fn get_builtins(primitives: &mut (PrimitiveStore, Unifier)) -> BuiltinInfo {
let boolean = primitives.0.bool;
let range = primitives.0.range;
let string = primitives.0.str;
// TODO(Derppening): Could we make this generic?

The issue tracker may be a more appropriate place for this.

The issue tracker may be a more appropriate place for this.
Poster
Collaborator

Opened #372.

Opened #372.
sb10q reviewed 2023-12-21 15:55:08 +08:00
@ -25,6 +25,7 @@ pub struct DefinitionId(pub usize);
pub mod builtins;
pub mod composer;
pub mod helper;
mod numpy;

Not pub?

Not pub?
derppening marked this conversation as resolved
derppening force-pushed enhance/issue-149-ndarray from 8abdaac562 to ef12ae062c 2023-12-22 16:05:35 +08:00 Compare
derppening force-pushed enhance/issue-149-ndarray from ef12ae062c to 140f8f8a08 2023-12-22 16:31:31 +08:00 Compare
Poster
Collaborator

v2, v3: Addressed above comments, added support for running ndarray.py tests in Python

v2, v3: Addressed above comments, added support for running `ndarray.py` tests in Python
sb10q merged commit 140f8f8a08 into master 2023-12-22 17:11:28 +08:00
sb10q deleted branch enhance/issue-149-ndarray 2023-12-22 17:11:29 +08:00
Sign in to join this conversation.
No reviewers
No Milestone
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#371
There is no content yet.