M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 99 Pull Requests 21 Releases Wiki Activity

Cleanup const generics implementation #363

Merged
sb10q merged 1 commits from feat/const-generics into master 2024-08-17 17:37:20 +08:00
Conversation 2 Commits 1 Files Changed 2 +13 -43
derppening commented 2023-12-11 13:03:58 +08:00
Collaborator
Copy Link

Change primarily revolves around passing ARTIQ builtins to the NAC3 constructor. artiq_builtins should be a dictionary mapping str to Any.

Change primarily revolves around passing ARTIQ builtins to the NAC3 constructor. `artiq_builtins` should be a dictionary mapping `str` to `Any`.
derppening self-assigned this 2023-12-11 13:03:58 +08:00
derppening requested review from sb10q 2023-12-11 13:04:08 +08:00
derppening force-pushed feat/const-generics from 3b38304838 to 2469ad1aaf 2023-12-11 15:18:04 +08:00 Compare
sb10q commented 2023-12-11 19:15:54 +08:00
Owner
Copy Link

Looks good to me. Just has the merge conflict since the clippy commits.

Looks good to me. Just has the merge conflict since the clippy commits.
derppening force-pushed feat/const-generics from 2469ad1aaf to beee3e1f7e 2023-12-12 11:28:12 +08:00 Compare
derppening commented 2023-12-12 11:28:50 +08:00
Author
Collaborator
Copy Link

v3: Rebased against master and applied clippy suggestions

Ready for merge.

v3: Rebased against master and applied clippy suggestions Ready for merge.
sb10q merged commit beee3e1f7e into master 2023-12-12 15:36:40 +08:00
sb10q deleted branch feat/const-generics 2023-12-12 15:36:41 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
sb10q
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
derppening
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#363
No description provided.
Delete Branch "feat/const-generics"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?