M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 99 Pull Requests 21 Releases Wiki Activity

artiq, core: Return HashSet of error messages for analysis #351

Merged
sb10q merged 3 commits from issue-190 into master 2023-12-12 15:42:00 +08:00
Conversation 7 Commits 3 Files Changed 18 +506 -333
derppening commented 2023-11-01 15:14:06 +08:00
Collaborator
Copy Link

Should help with #190.

TODO: What kernels can we use to test this?

Should help with #190. TODO: What kernels can we use to test this?
derppening self-assigned this 2023-11-01 15:14:06 +08:00
sb10q commented 2023-11-01 15:21:34 +08:00
Owner
Copy Link

TODO: What kernels can we use to test this?

Try porting the test suite, you'll probably get a flurry of errors :)

> TODO: What kernels can we use to test this? Try porting the test suite, you'll probably get a flurry of errors :)
derppening force-pushed issue-190 from 054271ca48 to fde13810f1 2023-11-01 18:05:23 +08:00 Compare
derppening commented 2023-11-01 18:05:56 +08:00
Author
Collaborator
Copy Link

v2: Rebased against master

v2: Rebased against master
derppening force-pushed issue-190 from fde13810f1 to 0fd659b0bd 2023-11-02 15:27:46 +08:00 Compare
derppening commented 2023-11-02 15:27:55 +08:00
Author
Collaborator
Copy Link

v3: Rebased against master

v3: Rebased against master
derppening force-pushed issue-190 from 0fd659b0bd to fd215ce4ed 2023-11-06 15:19:34 +08:00 Compare
derppening commented 2023-11-06 15:19:54 +08:00
Author
Collaborator
Copy Link

v4: Rebased against master, improved error message output for standalone

v4: Rebased against master, improved error message output for standalone
derppening force-pushed issue-190 from fd215ce4ed to 9a2249fd74 2023-11-09 15:37:32 +08:00 Compare
derppening commented 2023-11-09 15:37:44 +08:00
Author
Collaborator
Copy Link

v5: Rebased against master

v5: Rebased against master
derppening force-pushed issue-190 from 9a2249fd74 to 316c16d5a6 2023-11-15 17:35:34 +08:00 Compare
derppening force-pushed issue-190 from 316c16d5a6 to b949ce947a 2023-11-17 13:35:27 +08:00 Compare
derppening force-pushed issue-190 from b949ce947a to 28dedc0008 2023-12-12 13:32:27 +08:00 Compare
derppening commented 2023-12-12 13:33:45 +08:00
Author
Collaborator
Copy Link

v8: Refactored to return HashSet of Strings for now.

Let's use this as a temporary solution for now, we will refactor this into a proper Diagnostic class in the future.

v8: Refactored to return HashSet of Strings for now. Let's use this as a temporary solution for now, we will refactor this into a proper `Diagnostic` class in the future.
derppening changed title from WIP: artiq, core: Return HashSet of error messages for analysis to artiq, core: Return HashSet of error messages for analysis 2023-12-12 13:33:49 +08:00
derppening force-pushed issue-190 from 28dedc0008 to db88c3a78e 2023-12-12 13:51:39 +08:00 Compare
derppening commented 2023-12-12 13:52:17 +08:00
Author
Collaborator
Copy Link

v9: Remove redundant semicolons from return statements

v9: Remove redundant semicolons from `return` statements
sb10q merged commit 32746c37be into master 2023-12-12 15:42:00 +08:00
sb10q deleted branch issue-190 2023-12-12 15:42:00 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
derppening
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#351
No description provided.
Delete Branch "issue-190"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?