M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 98 Pull Requests 20 Releases Wiki Activity

Implement with legacy_parallel #348

Merged
sb10q merged 2 commits from enhance/with-legacy-parallel into master 2023-11-04 13:42:45 +08:00
Conversation 3 Commits 2 Files Changed 4 +101 -21
derppening commented 2023-10-30 18:18:02 +08:00
Collaborator
Copy Link

Implements legacy_parallel context similar to that of ARTIQ-7.

Implements `legacy_parallel` context similar to that of ARTIQ-7.
derppening self-assigned this 2023-10-30 18:18:02 +08:00
derppening added 5 commits 2023-10-30 18:18:03 +08:00
derppening added a new dependency 2023-10-30 19:38:48 +08:00
#347 Fix behavior of `with parallel`
derppening changed title from WIP: Implement `with legacy_parallel` to Implement `with legacy_parallel` 2023-10-31 10:37:57 +08:00
derppening changed title from Implement `with legacy_parallel` to Implement `with legacy_parallel` 2023-10-31 10:37:59 +08:00
derppening changed title from Implement `with legacy_parallel` to Implement `with legacy_parallel` 2023-10-31 10:38:04 +08:00
derppening requested review from sb10q 2023-10-31 10:38:15 +08:00
derppening force-pushed enhance/with-legacy-parallel from 5f42ca4d49 to 86017be4d0 2023-11-01 15:00:44 +08:00 Compare
derppening commented 2023-11-01 15:10:26 +08:00
Author
Collaborator
Copy Link

v2: Rebased against master

v2: Rebased against master
derppening force-pushed enhance/with-legacy-parallel from 86017be4d0 to db0134f21e 2023-11-01 18:04:55 +08:00 Compare
derppening commented 2023-11-01 18:05:07 +08:00
Author
Collaborator
Copy Link

v3: Rebased against master

v3: Rebased against master
sb10q reviewed 2023-11-01 20:00:45 +08:00
nac3artiq/src/codegen.rs Outdated
@ -29,0 +32,4 @@
/// No parallelism is currently registered for this context.
None,
/// Legacy (or shallow) parallelism. Default before ARTIQ-8.
sb10q commented 2023-11-01 20:00:45 +08:00
Owner
Copy Link

Just refer to "NAC3" since the ARTIQ-8 statement is actually incorrect and NAC3 is only tentatively planned for ARTIQ-9.

Just refer to "NAC3" since the ARTIQ-8 statement is actually incorrect and NAC3 is only tentatively planned for ARTIQ-9.
derppening marked this conversation as resolved
derppening force-pushed enhance/with-legacy-parallel from db0134f21e to f9e79a8ee7 2023-11-03 16:22:45 +08:00 Compare
derppening commented 2023-11-03 16:22:58 +08:00
Author
Collaborator
Copy Link

v4: Rebased against master, edited docs

v4: Rebased against master, edited docs
sb10q merged commit c2ab6b58ff into master 2023-11-04 13:42:45 +08:00
sb10q deleted branch enhance/with-legacy-parallel 2023-11-04 13:42:46 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
sb10q
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
derppening
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Depends on
#347 Fix behavior of `with parallel`
M-Labs/nac3
Reference: M-Labs/nac3#348
No description provided.
Delete Branch "enhance/with-legacy-parallel"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?