M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 97 Pull Requests 19 Releases Wiki Activity

standalone: Add output_bool in demo library #331

Merged
sb10q merged 1 commits from enhance/add-output-bool-to-demo-lib into master 2024-08-17 17:37:20 +08:00
Conversation 2 Commits 1 Files Changed 1 +10 -9
1 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit c5629d4eb5 - Show all commits

19
nac3standalone/demo/demo.c
View File

@ -12,30 +12,31 @@
#error "Unsupported platform - Platform is not 32-bit or 64-bit"
#endif
void output_bool(const bool x) {
void output_bool(bool x) {
sb10q commented 2023-10-05 16:52:44 +08:00
Outdated
Review
Copy Link

const?

const?
derppening commented 2023-10-06 10:21:40 +08:00
Outdated
Review
Copy Link

It's just to enforce an immutable-by-default design, similar to how objects in Rust are immutable unless mut is specified.

It's just to enforce an immutable-by-default design, similar to how objects in Rust are immutable unless `mut` is specified.
sb10q commented 2023-10-06 10:23:14 +08:00
Outdated
Review
Copy Link

Sounds like very idiosyncratic and probably ineffective C programming style.

Sounds like very idiosyncratic and probably ineffective C programming style.
derppening commented 2023-10-06 10:25:48 +08:00
Outdated
Review
Copy Link

Should I remove it then? It's just stylistic and doesn't change the ABI.

Should I remove it then? It's just stylistic and doesn't change the ABI.
sb10q commented 2023-10-06 10:26:03 +08:00
Outdated
Review
Copy Link

Yes, everywhere.

Yes, everywhere.
puts(x ? "True" : "False");
}
void output_int32(const int32_t x) {
void output_int32(int32_t x) {
printf("%d\n", x);
}
void output_int64(const int64_t x) {
void output_int64(int64_t x) {
printf("%ld\n", x);
}
void output_uint32(const uint32_t x) {
void output_uint32(uint32_t x) {
printf("%d\n", x);
}
void output_uint64(const uint64_t x) {
void output_uint64(uint64_t x) {
printf("%ld\n", x);
}
void output_float64(const double x) {
void output_float64(double x) {
printf("%f\n", x);
}
void output_asciiart(const int32_t x) {
void output_asciiart(int32_t x) {
static const char *chars = " .,-:;i+hHM$*#@ ";
if (x < 0) {
putchar('\n');
@ -45,12 +46,12 @@ void output_asciiart(const int32_t x) {
}
struct cslice {
const void *data;
void *data;
usize len;
};
void output_int32_list(struct cslice *slice) {
const int32_t *data = (const int32_t *) slice->data;
const int32_t *data = (int32_t *) slice->data;
putchar('[');
for (usize i = 0; i < slice->len; ++i) {