M-Labs
/
nac3
8
0
Fork 5
Code Issues 87 Pull Requests 3 Releases Wiki Activity

standalone: Add output_bool in demo library #331

Merged
sb10q merged 2 commits from enhance/add-output-bool-to-demo-lib into master 2023-10-06 10:38:30 +08:00
Conversation 2 Commits 2 Files Changed 3
derppening commented 2023-10-05 12:24:27 +08:00
Collaborator
There is no content yet.
derppening added 1 commit 2023-10-05 12:24:43 +08:00
sb10q reviewed 2023-10-05 16:52:44 +08:00
nac3standalone/demo/demo.c Outdated
@ -11,6 +12,10 @@
#error "Unsupported platform - Platform is not 32-bit or 64-bit"
#endif
void output_bool(const bool x) {
sb10q commented 2023-10-05 16:52:44 +08:00
Owner

const?

const?
derppening commented 2023-10-06 10:21:40 +08:00
Poster
Collaborator

It's just to enforce an immutable-by-default design, similar to how objects in Rust are immutable unless mut is specified.

It's just to enforce an immutable-by-default design, similar to how objects in Rust are immutable unless `mut` is specified.
sb10q commented 2023-10-06 10:23:14 +08:00
Owner

Sounds like very idiosyncratic and probably ineffective C programming style.

Sounds like very idiosyncratic and probably ineffective C programming style.
derppening commented 2023-10-06 10:25:48 +08:00
Poster
Collaborator

Should I remove it then? It's just stylistic and doesn't change the ABI.

Should I remove it then? It's just stylistic and doesn't change the ABI.
sb10q commented 2023-10-06 10:26:03 +08:00
Owner

Yes, everywhere.

Yes, everywhere.
derppening added 1 commit 2023-10-06 10:21:48 +08:00
derppening commented 2023-10-06 10:21:58 +08:00
Poster
Collaborator

v2: Rebased against master

v2: Rebased against master
derppening added 1 commit 2023-10-06 10:33:22 +08:00
derppening commented 2023-10-06 10:34:31 +08:00
Poster
Collaborator

v3: Removed most usages of const in demo library, except in some pointer-to-const cases.

v3: Removed most usages of `const` in demo library, except in some pointer-to-const cases.
sb10q merged commit c5629d4eb5 into master 2023-10-06 10:38:30 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
UROP0622
   
future-extension
   
high-priority
   
low-priority
No Label
UROP0622
future-extension
high-priority
low-priority
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#331
There is no content yet.
Delete Branch "enhance/add-output-bool-to-demo-lib"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?