artiq: Update host exception list to match possibly thrown types #329

Merged

sb10q merged 1 commits from issue-283 into master 2023-11-01 13:28:50 +08:00

Conversation 5 Commits 1 Files Changed 1

derppening commented 2023-10-03 14:07:09 +08:00

Collaborator

Match the list present in embedding_map.py with the list from lib.rs.

TODO: Any things I need to do to verify this fixes the problem?

Requires https://github.com/m-labs/artiq/pull/2269.

Fixes #283.

Match the list present in `embedding_map.py` with the list from `lib.rs`. ~~TODO: Any things I need to do to verify this fixes the problem?~~ Requires https://github.com/m-labs/artiq/pull/2269. Fixes #283.

derppening added 1 commit 2023-10-03 14:07:09 +08:00

a15b40890d artiq: Update host exception list to match possibly thrown types

sb10q commented 2023-10-03 22:11:03 +08:00

Owner

Which lib.rs ?

TODO: Any things I need to do to verify this fixes the problem?

Raise the exceptions on hardware and check that you get the Python ones after the kernel finishes.

Which lib.rs ? > TODO: Any things I need to do to verify this fixes the problem? Raise the exceptions on hardware and check that you get the Python ones after the kernel finishes.

derppening force-pushed issue-283 from a15b40890d to dbdadb2ece 2023-10-06 13:13:11 +08:00 Compare

derppening force-pushed issue-283 from dbdadb2ece to 73d95b08dc 2023-10-12 14:50:13 +08:00 Compare

derppening commented 2023-10-12 15:44:21 +08:00

Poster

Collaborator

v2, v3: Rebased against master

Which lib.rs ?

nac3artiq/src/lib.rs, in compile_method.

Raise the exceptions on hardware and check that you get the Python ones after the kernel finishes.

Unfortunately I cannot reproduce the issue when explicitly raising the exception, similar to what reported by Anto here. I might need a Urukul device to test this with.

v2, v3: Rebased against `master` > Which lib.rs ? `nac3artiq/src/lib.rs`, in `compile_method`. > Raise the exceptions on hardware and check that you get the Python ones after the kernel finishes. Unfortunately I cannot reproduce the issue when explicitly raising the exception, similar to what reported by Anto [here](https://git.m-labs.hk/M-Labs/nac3/issues/283). I might need a Urukul device to test this with.

derppening force-pushed issue-283 from 73d95b08dc to 277295cce5 2023-10-16 16:03:21 +08:00 Compare

derppening commented 2023-10-16 16:06:51 +08:00

Poster

Collaborator

v4: Rebased against master

v4: Rebased against `master`

derppening force-pushed issue-283 from 277295cce5 to 1d3f9a65c5 2023-10-23 10:04:41 +08:00 Compare

derppening commented 2023-10-23 10:08:04 +08:00

Poster

Collaborator

v5: Rebased against master

v5: Rebased against `master`

derppening force-pushed issue-283 from 1d3f9a65c5 to e1d354160d 2023-10-30 14:00:34 +08:00 Compare

derppening commented 2023-10-30 15:18:06 +08:00

Poster

Collaborator

v6: Rebased against mater, linked with issue in artiq.

v6: Rebased against mater, linked with issue in `artiq`.

derppening changed title from WIP: artiq: Update host exception list to match possibly thrown types to artiq: Update host exception list to match possibly thrown types 2023-10-30 15:18:16 +08:00

derppening self-assigned this 2023-10-30 17:23:25 +08:00

derppening requested review from sb10q 2023-10-30 17:23:29 +08:00

sb10q merged commit 352f70b885 into master 2023-11-01 13:28:50 +08:00

sb10q deleted branch issue-283 2023-11-01 13:28:53 +08:00

Sign in to join this conversation.

Reviewers

No reviewers

sb10q

Labels

Clear labels   

UROP0622

  

future-extension

  

high-priority

  

low-priority

No Label

UROP0622

future-extension

high-priority

low-priority

Milestone

Clear milestone

No items

No Milestone

Assignees

Clear assignees

No Assignees

derppening

2 Participants

Notifications

Subscribe

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#329

There is no content yet.