M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 99 Pull Requests 21 Releases Wiki Activity

master #311

Closed
Aadityavardhan wants to merge 8 commits from (deleted):master into master
pull from: (deleted):master
merge into: M-Labs:master
Conversation 2 Commits 8 Files Changed 133 +49 -6
Aadityavardhan commented 2022-08-21 12:35:03 +08:00
First-time contributor
Copy Link

WIP: Static Class Attributes

Enabled class attribute definition syntax in the class body (Imp: Type checking/expression folding needs to be done).
Modified init checker to ensure that static fields do not need to be initialised in init.

**WIP: Static Class Attributes** Enabled class attribute definition syntax in the class body (Imp: Type checking/expression folding needs to be done). Modified init checker to ensure that static fields do not need to be initialised in __init__.
Aadityavardhan added 5 commits 2022-08-21 12:35:05 +08:00
sb10q reviewed 2022-08-21 16:31:16 +08:00
.gitignore Outdated
@ -4,0 +6,4 @@
interpreted.log
nac3standalone/demo/module.o
nac3standalone/demo/demo
nac3standalone/demo/run.log
sb10q commented 2022-08-21 16:31:16 +08:00
Owner
Copy Link

Remove

Remove
sb10q commented 2022-08-21 16:31:31 +08:00
Owner
Copy Link

Please fix the file permission issues that pollute this patch.

Please fix the file permission issues that pollute this patch.
sb10q reviewed 2022-08-21 16:32:18 +08:00
nac3core/src/toplevel/builtins.rs Outdated
@ -175,6 +177,8 @@ pub fn get_builtins(primitives: &mut (PrimitiveStore, Unifier)) -> BuiltinInfo {
type_vars: Default::default(),
fields: exception_fields,
methods: Default::default(),
// Make TopLevelDef::Class initlializer compatible
sb10q commented 2022-08-21 16:32:18 +08:00
Owner
Copy Link

Typo
What does that mean anyway?

Typo What does that mean anyway?
Aadityavardhan commented 2022-08-21 18:11:37 +08:00
Author
First-time contributor
Copy Link

To call out the newly introduced static_fields data member in the TopLevelDef::Class struct.

To call out the newly introduced static_fields data member in the TopLevelDef::Class struct.
sb10q reviewed 2022-08-21 16:32:40 +08:00
nac3core/src/typecheck/typedef/mod.rs Outdated
@ -514,3 +514,3 @@
fn unify_impl(&mut self, a: Type, b: Type, swapped: bool) -> Result<(), TypeError> {
use TypeEnum::*;
sb10q commented 2022-08-21 16:32:39 +08:00
Owner
Copy Link

Remove

Remove
sb10q commented 2022-08-21 16:33:19 +08:00
Owner
Copy Link

Please title this PR properly. "master" is definitely not a good title.

Please title this PR properly. "master" is definitely not a good title.
Aadityavardhan added 1 commit 2022-08-21 17:19:49 +08:00
fc8b69c3cd Updated .gitignore 
Removed unnecessary filenames
Aadityavardhan added 2 commits 2022-08-21 18:24:11 +08:00
Aadityavardhan closed this pull request 2022-08-21 20:30:33 +08:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#311
No description provided.
Delete Branch "(deleted):master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?