M-Labs/nac3
M-Labs
/
nac3
8
0
Fork 10
Code Issues 98 Pull Requests 18 Releases Wiki Activity

Correct global name for const object for RPC #289

Merged
sb10q merged 1 commits from 272-key-err-rpc-fix into master 2022-05-17 11:53:13 +08:00
Conversation 1 Commits 1 Files Changed 1 +1 -1
ychenfo commented 2022-05-17 03:12:53 +08:00
Collaborator
Copy Link

Despite #283, this simple patch should be able to fix #272.

Previously the llvm global value name is wrong, causing the wrong key to be sent to the host embedding map.

Despite #283, this simple patch should be able to fix #272. Previously the llvm global value name is wrong, causing the wrong key to be sent to the host embedding map.
ychenfo added 1 commit 2022-05-17 03:12:54 +08:00
sb10q commented 2022-05-17 11:07:44 +08:00
Owner
Copy Link

I don't think #283 and #272 are related. #283 should be a simple matter of fixing the inconsistency in the multiple places where builtin exceptions are defined; in particular, ValueError is not defined consistently.

I don't think #283 and #272 are related. #283 should be a simple matter of fixing the inconsistency in the multiple places where builtin exceptions are defined; in particular, ValueError is not defined consistently.
sb10q merged commit 2cb725b7ac into master 2022-05-17 11:53:13 +08:00
sb10q deleted branch 272-key-err-rpc-fix 2022-05-17 11:53:15 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
future-extension

   
high-priority

   
low-priority

   
UROP0622
No Label
future-extension
high-priority
low-priority
UROP0622
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#289
No description provided.
Delete Branch "272-key-err-rpc-fix"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?