nac3artiq: handle recursive types properly #236

ychenfo · 2022-03-23T03:51:09+08:00

ychenfo commented

2022-03-23 03:51:09 +08:00

Notice this issue when modifying the code to change from using None to none to represent nac3 option type

This is an attempt to redo d41c923cfd, which seems to be forgotten in the recent commit, with more fixes (using id instead of ty_id, and the fix on get_symbol_value which if not fixed will give me something like ../my_expr/artiq/module.elf: undefined symbol: 140036270644720" when runkernel with host object of recursive types).

Notice this issue when modifying the code to change from using `None` to `none` to represent nac3 option type This is an attempt to redo https://git.m-labs.hk/M-Labs/nac3/commit/d41c923cfdc71979d5007a53cd3adad2798abe82, which seems to be forgotten in the recent commit, with more fixes (using id instead of ty_id, and the fix on `get_symbol_value` which if not fixed will give me something like `../my_expr/artiq/module.elf: undefined symbol: 140036270644720"` when runkernel with host object of recursive types).

sb10q requested review from pca006132 2022-03-23 08:55:22 +08:00

ychenfo force-pushed recursive_host_type from 862af24dfd to d92cd3c7a0

2022-03-26 03:09:07 +08:00

Compare

ychenfo commented

2022-03-26 03:09:38 +08:00

force-pushed to rebse on the lastest master branch

pca006132 approved these changes 2022-03-26 18:43:12 +08:00

ychenfo force-pushed recursive_host_type from d92cd3c7a0 to ba8ed6c663

2022-03-26 18:55:42 +08:00

Compare

sb10q merged commit ba8ed6c663 into master

2022-03-26 20:06:16 +08:00

sb10q deleted branch recursive_host_type

2022-03-26 20:06:17 +08:00

Sign in to join this conversation.

No reviewers

No Label

No Milestone

No Assignees

2 Participants

Notifications

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/nac3#236