M-Labs/kirdy
4
0
Fork 4
Code Issues 14 Pull Requests 1 Projects Releases Wiki Activity

Fix nix build compilation error at Check Phase #1

Merged
sb10q merged 1 commits from linuswck/kirdy-firmware:fix_nix_build_compilation into master 2023-12-15 16:40:03 +08:00
Conversation 1 Commits 1 Files Changed 1 +6 -5
linuswck commented 2023-12-15 14:40:44 +08:00
Member
Copy Link

PR Description

This PR fixes the compilation error on nix build .

At Check Phase, cargo test -j 16 --release --target x86_64-unknown-linux-gnu --frozen -- --test-threads=16 is run.
The compilation errors are due to:

  • "panic_handler" is declared at test
  • "no_main" and "no_std" are declared at test
  • kirdy's firmware "main" fn is declared
# PR Description This PR fixes the compilation error on `nix build .` At Check Phase, `cargo test -j 16 --release --target x86_64-unknown-linux-gnu --frozen -- --test-threads=16` is run. The compilation errors are due to: - "panic_handler" is declared at test - "no_main" and "no_std" are declared at test - kirdy's firmware "main" fn is declared
linuswck added 1 commit 2023-12-15 14:40:44 +08:00
Fix nix build to compilation error at Check Phase f2b419f8d0 
- "panic_handler" should not be declared during test
- "main" and "std" are needed during test
linuswck changed target branch from rtic to master 2023-12-15 14:41:11 +08:00
sb10q merged commit f2b419f8d0 into master 2023-12-15 16:40:03 +08:00
sb10q commented 2023-12-15 16:40:21 +08:00
Owner
Copy Link

Just commit and push directly. This repos is only for testing and won't be the final firmware.

Just commit and push directly. This repos is only for testing and won't be the final firmware.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
fsagbuya jordens linuswck sb10q
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: M-Labs/kirdy#1
Delete Branch "linuswck/kirdy-firmware:fix_nix_build_compilation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?