M-Labs
/
compiler-builtins-zynq
8
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

address second row of review

master
Jorge Aparicio 2016-08-11 01:45:48 -05:00
parent 1c22269948
commit eb206842f2
1 changed files with 3 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
src/div.rs
View File

@ -7,7 +7,7 @@ pub extern "C" fn __udivsi3(n: u32, d: u32) -> u32 {
// Special cases // Special cases
if d == 0 { if d == 0 {
return 0; // ?! panic!("Division by zero");
} }
if n == 0 { if n == 0 {
@ -49,8 +49,7 @@ pub extern "C" fn __udivsi3(n: u32, d: u32) -> u32 {
r -= d & s as u32; r -= d & s as u32;
} }
q = (q << 1) | carry; (q << 1) | carry
q
} }
/// Returns `n / d` and sets `*rem = n % d` /// Returns `n / d` and sets `*rem = n % d`
@ -105,13 +104,7 @@ pub extern "C" fn __udivmoddi4(n: u64, d: u64, rem: Option<&mut u64>) -> u64 {
// --- // ---
// 0 0 // 0 0
// NOTE copied verbatim from compiler-rt. This probably lets the intrinsic decide how to panic!("Division by zero");
// handle the division by zero (SIGFPE, 0, etc.). But this part shouldn't be reachable
// from safe code.
if let Some(rem) = rem {
*rem = u64::from(n.high() % d.low());
}
return u64::from(n.high() / d.low());
} }
// d.high() != 0 // d.high() != 0