M-Labs
/
artiq-zynq
9
1
Fork 16
Code Issues 13 Pull Requests 1 Releases Wiki Activity

Port io_expander code from Kasli #214

Merged
sb10q merged 4 commits from esavkin/artiq-zynq:213-sfp-fiber-support into master 2023-02-16 10:29:06 +08:00
Conversation 1 Commits 4 Files Changed 2
esavkin commented 2023-02-15 17:46:53 +08:00
Owner

Closes #213

Enables SFP fiber support in Kasli SoC.

Needs to be applied to release-7 branch

Closes #213 Enables SFP fiber support in Kasli SoC. Needs to be applied to release-7 branch
esavkin added 3 commits 2023-02-15 17:46:53 +08:00
4bc936f071 Copy io expander from kasli 
Signed-off-by: Egor Savkin <es@m-labs.hk>
8230a01701 Build io_expander 
Signed-off-by: Egor Savkin <es@m-labs.hk>
b4b7912c40 Port tx_disable-related code from Kasli 
Signed-off-by: Egor Savkin <es@m-labs.hk>
esavkin added 1 commit 2023-02-15 18:14:07 +08:00
ca6e0d13ad Remove virtual LEDs from io_expander 
Signed-off-by: Egor Savkin <es@m-labs.hk>
esavkin changed title from WIP: Port io_expander code from Kasli to Port io_expander code from Kasli 2023-02-15 18:43:22 +08:00
sb10q reviewed 2023-02-16 10:11:33 +08:00
src/runtime/src/main.rs
@ -117,0 +122,4 @@
io_expander0.init().expect("I2C I/O expander #0 initialization failed");
io_expander1.init().expect("I2C I/O expander #1 initialization failed");
// Actively drive TX_DISABLE to false on SFP0..3
sb10q commented 2023-02-16 10:11:33 +08:00
Owner

Needs to be done in satman as well.

Needs to be done in satman as well.
esavkin commented 2023-02-16 10:21:16 +08:00
Poster
Owner

Maybe do it in another PR? It looks like i2c logic in satman needs to be refactored to make io_expander shared

Maybe do it in another PR? It looks like i2c logic in satman needs to be refactored to make io_expander shared
sb10q commented 2023-02-16 10:28:47 +08:00
Owner

Looks like it's a super simple "refactoring" but ok if you want...

Looks like it's a super simple "refactoring" but ok if you want...
sb10q commented 2023-02-16 10:17:03 +08:00
Owner

Seems acceptable otherwise.

Seems acceptable otherwise.
sb10q merged commit b85c870b82 into master 2023-02-16 10:29:06 +08:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
priority:critical
   
priority:high
   
priority:low
   
priority:medium
No Label
priority:critical
priority:high
priority:low
priority:medium
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: M-Labs/artiq-zynq#214
There is no content yet.
Delete Branch "esavkin/artiq-zynq:213-sfp-fiber-support"

Deleting a branch is permanent. Although the deleted branch may exist for a short time before cleaning up, in most cases it CANNOT be undone. Continue?