• Joined on 2021-03-29
ychenfo pushed to err_msg_improvement at M-Labs/nac3 2021-11-26 04:23:33 +08:00
934cf0534b nac3core: fix broken tests due to change of error message
99880f6afb nac3core: error msg add location in some trivial cases
Compare 2 commits »
ychenfo pushed to symbol_resolver_typevar at M-Labs/nac3 2021-11-24 18:53:36 +08:00
dada7d6688 nac3standalone: remove another panic in main
f7c8f222dd nac3standalone: remove panic in main
Compare 2 commits »
ychenfo commented on pull request M-Labs/nac3#99 2021-11-24 18:53:00 +08:00
TypeVar and virtual support in Symbol Resolver

Also panic in nac3standalone is acceptable, this is just a demonstration program.

Ok I see, I will remove the commits about removing panics.

ychenfo commented on pull request M-Labs/nac3#99 2021-11-24 18:50:27 +08:00
TypeVar and virtual support in Symbol Resolver

Hi, the new commits resolves the conflict, and support iteration over multiple typevar assignments in the same line. I will also see if my previous PRs introduce the bug newly found..

ychenfo pushed to symbol_resolver_typevar at M-Labs/nac3 2021-11-24 18:47:01 +08:00
dada7d6688 nac3standalone: remove another panic in main
ychenfo pushed to symbol_resolver_typevar at M-Labs/nac3 2021-11-24 18:42:51 +08:00
f7c8f222dd nac3standalone: remove panic in main
49240a80ad nac3standalone: iteration over multiple typevar assignment in the same line
34105b4f0e Merge remote-tracking branch 'origin/master' into symbol_resolver_typevar
0ae1fe82b4 remove unnecessary cargo config
de8fc264d7 fix unsupported default parameter error message
Compare 16 commits »
ychenfo pushed to default_parameter at M-Labs/nac3 2021-11-23 01:43:13 +08:00
03cdca606d nac3core: check type for default parameter
5097e9e15a nac3core: check type for default parameter
Compare 2 commits »
ychenfo commented on pull request M-Labs/nac3#99 2021-11-23 01:09:26 +08:00
TypeVar and virtual support in Symbol Resolver

Thanks for pointing this out, yes this and the previous issue about iterating over assignment should be resolved. Sorry that I forgot to handle these earlier..

Since this is basically the same…

ychenfo commented on pull request M-Labs/nac3#98 2021-11-23 01:05:45 +08:00
Constant Default Parameter Support

This is supported in the latest commit, as well as a better type check for default parameter, please have a review, thanks!

ychenfo pushed to default_parameter at M-Labs/nac3 2021-11-23 01:03:19 +08:00
5097e9e15a nac3core: check type for default parameter
99c103b35b nac3standalone: better support for global assignment
Compare 2 commits »
ychenfo pushed to symbol_resolver_typevar at M-Labs/nac3 2021-11-22 15:10:56 +08:00
fe4fbdc5db cleanup println
ychenfo pushed to polymorphism_fixes at M-Labs/nac3 2021-11-22 15:06:36 +08:00
49476d06e1 nac3core: clearer comments
664e02cec4 nac3core: fix clippy warning
c6f75c8bde nac3standalone: fix error message when no entry point is found
Compare 3 commits »
ychenfo commented on pull request M-Labs/nac3#104 2021-11-22 14:46:01 +08:00
Polymorphism Fixes

To change the way to check whether a function is instantiated (e.g., as long as there exits one uninstantiated type vars, the function is not instantiated)

Thanks for pointing it out, I will also…

ychenfo commented on pull request M-Labs/nac3#104 2021-11-22 14:42:49 +08:00
Polymorphism Fixes

Yes, here since we are concretizing types, all class fields should not have type vars. But due to partial instantiation of class methods, there might still be some methods whose signature contains…

ychenfo commented on pull request M-Labs/nac3#99 2021-11-22 14:34:13 +08:00
TypeVar and virtual support in Symbol Resolver

Sorry for the unclear comment. Here I mean that before this line in min_artiq.py: compiler = nac3artiq.NAC3(core_arguments["target"]), the class virtual should already be known to CPython…

ychenfo commented on pull request M-Labs/nac3#98 2021-11-22 14:18:55 +08:00
Constant Default Parameter Support

Oh sure, now the symbol resolver change is ok, I will add this support now.

ychenfo commented on pull request M-Labs/nac3#98 2021-11-21 22:32:52 +08:00
Constant Default Parameter Support

Would it be acceptable that in artiq, we just enforce and document that the self should always be self and should not be named arbitrarily? As I think this would not cause very big problems and…

ychenfo commented on pull request M-Labs/nac3#98 2021-11-21 22:18:48 +08:00
Constant Default Parameter Support

I have added the basic module primitive/tuple global default parameter in the new commit.

No eval is used, only simple variable name is supported, but still involve some changes in symbol…

ychenfo pushed to default_parameter at M-Labs/nac3 2021-11-21 22:07:53 +08:00
ee7c1eb11d nac3core: change default parameter integer out of range err msg
59bdb1be50 nac3core: change default parameter integer out of range err msg
Compare 2 commits »
ychenfo commented on pull request M-Labs/nac3#98 2021-11-21 22:06:51 +08:00
Constant Default Parameter Support

Thanks, this error message is updated in the new commit