ychenfo

ychenfo commented on issue M-Labs/nac3#73

2021-12-19 03:06:24 +08:00

support strings as type annotations

Is this done?

Not yet. There seems to be not much progress on this on how Python will resolve this.

ychenfo commented on pull request M-Labs/nac3#128

2021-12-19 03:02:01 +08:00

For loop type inference fix

A proper fix would be to change the type system to allow for iterator type, which can be range type, list type or other user defined iterators.

Ah I get it, yes and I think for this issue (#137)…

ychenfo commented on pull request M-Labs/nac3#127

2021-12-19 02:57:06 +08:00

Kernel only attribute annotation (#76)

I meant Default for ComposerConfig.

Implemented in the new commmit.

ychenfo pushed to kernel_only_annotation at M-Labs/nac3

2021-12-19 02:55:45 +08:00

cbf83bcc8c nac3core/standalone: use default for ComposerConfig

ychenfo commented on pull request M-Labs/nac3#127

2021-12-18 05:00:11 +08:00

Kernel only attribute annotation (#76)

Misleading comment. I suggest removing it, since it's fairly obvious what this does from the code already.

Oh I see, removed in the latest commit.

We may want to refactor this at some point…

ychenfo pushed to kernel_only_annotation at M-Labs/nac3

2021-12-18 04:54:51 +08:00

5f24d63b0b nac3core: remove misleading comment

ychenfo created pull request M-Labs/nac3#140

2021-12-18 04:53:12 +08:00

WIP: List Slice Support

ychenfo pushed to list_slice at M-Labs/nac3

2021-12-18 04:45:13 +08:00

5d23776ec9 nac3core: get list slice

ychenfo created branch list_slice in M-Labs/nac3

2021-12-18 04:45:12 +08:00

ychenfo commented on pull request M-Labs/nac3#128

2021-12-17 05:15:49 +08:00

For loop type inference fix

I think for some more time and the major problem seems to be the unification between the type var var1(range = [list[var2], range])(list of something or range), and the type `list[some concrete…

ychenfo pushed to kernel_only_annotation at M-Labs/nac3

2021-12-17 04:44:29 +08:00

dba165d95c nac3core/artiq/standalone: composer only config kernel annotation names

ychenfo commented on issue M-Labs/nac3#133

2021-12-15 03:03:04 +08:00

fields broken with inheritance

I think this field initialization check problem is also related to the super (#136) and somehow related to the module type (#40) (should be 'class type' here though).. So maybe we should settle how…

ychenfo commented on issue M-Labs/nac3#134

2021-12-15 02:38:28 +08:00

check array bounds

Things related to the slice also needs these array bounds checks.. I am not sure.. should this be implemented after the exception since array bound cannot be easily checked statically?

ychenfo commented on pull request M-Labs/nac3#127

2021-12-15 02:32:24 +08:00

Kernel only attribute annotation (#76)

Thanks for the above suggestions, they are implemented in the new commits.

ychenfo pushed to kernel_only_annotation at M-Labs/nac3

2021-12-15 02:29:43 +08:00

6ce2f1b7ec Merge remote-tracking branch 'origin/master' into kernel_only_annotation

bd97f89514 nac3core/artiq/standalone: implement kernel annotation with core mode selection

39220e8354 Revert "nac3core/artiq: implement Kernel annotation" and "nac3artiq: add kernel only annotation demo"

7420ce185b README: update

69b9ac5152 nac3standalone: consistent naming

Compare 9 commits »

ychenfo created pull request M-Labs/nac3#130

2021-12-13 04:26:06 +08:00

nac3core: fix bool to int conversion

ychenfo commented on pull request M-Labs/nac3#127

2021-12-13 04:22:15 +08:00

Kernel only attribute annotation (#76)

Currently we are always in __init__ since there is no RPC.

Sorry I think I do not quite get what you mean here, now in nac3artiq we are also outside of __init__ when we are not constructing…

ychenfo commented on pull request M-Labs/nac3#129

2021-12-13 04:16:15 +08:00

nac3core: fix len on range with step of different sign

Thanks a lot for the information! I implemented again using this now.

ychenfo pushed to bool_to_int_fix at M-Labs/nac3

2021-12-13 04:14:34 +08:00

82359b81a2 nac3core: fix bool to int conversion

ychenfo created branch bool_to_int_fix in M-Labs/nac3

2021-12-13 04:14:33 +08:00